* Re: [PATCH 01/14] brcmfmac: add delay before unregistering the network device [not found] ` <1393413044.4133.6.camel@jlt4.sipsolutions.net> @ 2014-02-26 11:34 ` Arend van Spriel 2014-02-26 11:48 ` Johannes Berg 0 siblings, 1 reply; 5+ messages in thread From: Arend van Spriel @ 2014-02-26 11:34 UTC (permalink / raw) To: Johannes Berg; +Cc: John W. Linville, linux-wireless, David Miller, netdev On 02/26/2014 12:10 PM, Johannes Berg wrote: > On Wed, 2014-02-26 at 11:43 +0100, Arend van Spriel wrote: > >> Actually, this was not the reason for the doing the msleep(). The >> problem was that wpa_supplicant received RTM_DELLINK, before getting the >> NL08211_DISCONNECT. This resulted in RTM_DELLINK, immediately followed >> by RTM_ADDLINK, followed by NL80211_DISCONNECT. > > I'm not sure this isn't still possible? I don't know when DELLINK is > sent. Given the behaviour I would say before the netdev notifier, which may be considered wrong. It depends whether the notifier was intended for the kind of thing that cfg80211 is doing, ie. send a netlink event to user-space? Gr. AvS ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 01/14] brcmfmac: add delay before unregistering the network device 2014-02-26 11:34 ` [PATCH 01/14] brcmfmac: add delay before unregistering the network device Arend van Spriel @ 2014-02-26 11:48 ` Johannes Berg 2014-02-26 12:18 ` Arend van Spriel 0 siblings, 1 reply; 5+ messages in thread From: Johannes Berg @ 2014-02-26 11:48 UTC (permalink / raw) To: Arend van Spriel; +Cc: John W. Linville, linux-wireless, David Miller, netdev On Wed, 2014-02-26 at 12:34 +0100, Arend van Spriel wrote: > > I'm not sure this isn't still possible? I don't know when DELLINK is > > sent. > > Given the behaviour I would say before the netdev notifier, which may be > considered wrong. It depends whether the notifier was intended for the > kind of thing that cfg80211 is doing, ie. send a netlink event to > user-space? Well, I checked: call_netdevice_notifiers(NETDEV_UNREGISTER, dev); if (!dev->rtnl_link_ops || dev->rtnl_link_state == RTNL_LINK_INITIALIZED) rtmsg_ifinfo(RTM_DELLINK, dev, ~0U, GFP_KERNEL); so ... :) johannes ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 01/14] brcmfmac: add delay before unregistering the network device 2014-02-26 11:48 ` Johannes Berg @ 2014-02-26 12:18 ` Arend van Spriel 2014-02-26 12:22 ` Johannes Berg 0 siblings, 1 reply; 5+ messages in thread From: Arend van Spriel @ 2014-02-26 12:18 UTC (permalink / raw) To: Johannes Berg; +Cc: John W. Linville, linux-wireless, David Miller, netdev On 02/26/2014 12:48 PM, Johannes Berg wrote: > On Wed, 2014-02-26 at 12:34 +0100, Arend van Spriel wrote: > >>> I'm not sure this isn't still possible? I don't know when DELLINK is >>> sent. >> >> Given the behaviour I would say before the netdev notifier, which may be >> considered wrong. It depends whether the notifier was intended for the >> kind of thing that cfg80211 is doing, ie. send a netlink event to >> user-space? > > Well, I checked: > > call_netdevice_notifiers(NETDEV_UNREGISTER, dev); > > if (!dev->rtnl_link_ops || > dev->rtnl_link_state == RTNL_LINK_INITIALIZED) > rtmsg_ifinfo(RTM_DELLINK, dev, ~0U, GFP_KERNEL); > > so ... :) Feeling sad :-( but thanks for checking. Clearly need to look into this some more. John, can you please drop this one. Gr. AvS ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 01/14] brcmfmac: add delay before unregistering the network device 2014-02-26 12:18 ` Arend van Spriel @ 2014-02-26 12:22 ` Johannes Berg 2014-02-26 12:35 ` Arend van Spriel 0 siblings, 1 reply; 5+ messages in thread From: Johannes Berg @ 2014-02-26 12:22 UTC (permalink / raw) To: Arend van Spriel; +Cc: John W. Linville, linux-wireless, David Miller, netdev On Wed, 2014-02-26 at 13:18 +0100, Arend van Spriel wrote: > Feeling sad :-( but thanks for checking. Clearly need to look into this > some more. John, can you please drop this one. I think you probably still want to drop the other sleep? johannes ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 01/14] brcmfmac: add delay before unregistering the network device 2014-02-26 12:22 ` Johannes Berg @ 2014-02-26 12:35 ` Arend van Spriel 0 siblings, 0 replies; 5+ messages in thread From: Arend van Spriel @ 2014-02-26 12:35 UTC (permalink / raw) To: Johannes Berg; +Cc: John W. Linville, linux-wireless, David Miller, netdev On 02/26/2014 01:22 PM, Johannes Berg wrote: > On Wed, 2014-02-26 at 13:18 +0100, Arend van Spriel wrote: > >> Feeling sad :-( but thanks for checking. Clearly need to look into this >> some more. John, can you please drop this one. > > I think you probably still want to drop the other sleep? Yeah. That one is pretty useless anyway given that it is under rtnl_lock. Just want to check that it works when I remove the sleep between cfg80211_disconnected() and unregister_netdev() as well. Gr. AvS ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-26 12:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1393356639-19169-1-git-send-email-arend@broadcom.com>
[not found] ` <1393356639-19169-2-git-send-email-arend@broadcom.com>
[not found] ` <1393358376.4170.22.camel@jlt4.sipsolutions.net>
[not found] ` <530DAECD.8010405@broadcom.com>
[not found] ` <1393406278.4133.4.camel@jlt4.sipsolutions.net>
[not found] ` <530DB3BA.20106@broadcom.com>
[not found] ` <1393407473.4133.5.camel@jlt4.sipsolutions.net>
[not found] ` <530DC56E.9040202@broadcom.com>
[not found] ` <1393413044.4133.6.camel@jlt4.sipsolutions.net>
2014-02-26 11:34 ` [PATCH 01/14] brcmfmac: add delay before unregistering the network device Arend van Spriel
2014-02-26 11:48 ` Johannes Berg
2014-02-26 12:18 ` Arend van Spriel
2014-02-26 12:22 ` Johannes Berg
2014-02-26 12:35 ` Arend van Spriel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).