From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend van Spriel Subject: Re: [PATCH 01/14] brcmfmac: add delay before unregistering the network device Date: Wed, 26 Feb 2014 13:35:45 +0100 Message-ID: <530DDFA1.4000102@broadcom.com> References: <1393356639-19169-1-git-send-email-arend@broadcom.com> <1393356639-19169-2-git-send-email-arend@broadcom.com> (sfid-20140225_203048_842452_A39499B6) <1393358376.4170.22.camel@jlt4.sipsolutions.net> <530DAECD.8010405@broadcom.com> <1393406278.4133.4.camel@jlt4.sipsolutions.net> <530DB3BA.20106@broadcom.com> <1393407473.4133.5.camel@jlt4.sipsolutions.net> <530DC56E.9040202@broadcom.com> <1393413044.4133.6.camel@jlt4.sipsolutions.net> <530DD131.50205@broadcom.com> <1393415288.4133.7.camel@jlt4.sipsolutions.net> <530DDB91.3070807@broadcom.com> <1393417325.4133.8.camel@jlt4.sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "John W. Linville" , linux-wireless , David Miller , To: Johannes Berg Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:10533 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbaBZMft (ORCPT ); Wed, 26 Feb 2014 07:35:49 -0500 In-Reply-To: <1393417325.4133.8.camel@jlt4.sipsolutions.net> Sender: netdev-owner@vger.kernel.org List-ID: On 02/26/2014 01:22 PM, Johannes Berg wrote: > On Wed, 2014-02-26 at 13:18 +0100, Arend van Spriel wrote: > >> Feeling sad :-( but thanks for checking. Clearly need to look into this >> some more. John, can you please drop this one. > > I think you probably still want to drop the other sleep? Yeah. That one is pretty useless anyway given that it is under rtnl_lock. Just want to check that it works when I remove the sleep between cfg80211_disconnected() and unregister_netdev() as well. Gr. AvS