Re: [PATCH 3/7] bridge: Add addresses from static fdbs to bridge address list

[Vlad Yasevich <vyasevic@redhat.com>]

On 02/26/2014 11:57 AM, Stephen Hemminger wrote:
> On Wed, 26 Feb 2014 10:18:21 -0500
> Vlad Yasevich <vyasevic@redhat.com> wrote:
> 
>> When a static fdb entry is created, add the mac address to the bridge
>> address list.  This list is used to program the proper port's
>> address list.
>>
>> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
> 
> I don't like this level of bookkeeping it starts to mix
> layers between the bridge network interface as entity for talking to the
> local host, and forwarding table entries.

Actually this is one of the reasons this isn't done through the
br->dev->uc.  Forwarding table entries are still per-port.

> 
> Many times static entries are used as alternative to flooding in
> environments which don't trust STP.

Ok, and how would this be problematic?  If one wants to turn off
promisc in this environment, then receive filters needs to be properly
programmed.

> 
> Plus, it looks like another major source of bugs.
> 

Any new code is a potential source of issues.  Are you saying
No to any new code in bridge?

-vlad