* [PATCH net-next] neigh: directly goto out after setting nud_state to NUD_FAILED
@ 2014-02-27 9:03 Duan Jiong
2014-02-27 21:41 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Duan Jiong @ 2014-02-27 9:03 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Because those following if conditions will not be matched.
Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
---
net/core/neighbour.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index b9e9e0d..026bfd1 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -945,6 +945,7 @@ static void neigh_timer_handler(unsigned long arg)
neigh->nud_state = NUD_FAILED;
notify = 1;
neigh_invalidate(neigh);
+ goto out;
}
if (neigh->nud_state & NUD_IN_TIMER) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] neigh: directly goto out after setting nud_state to NUD_FAILED
2014-02-27 9:03 [PATCH net-next] neigh: directly goto out after setting nud_state to NUD_FAILED Duan Jiong
@ 2014-02-27 21:41 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-02-27 21:41 UTC (permalink / raw)
To: duanj.fnst; +Cc: netdev
From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Date: Thu, 27 Feb 2014 17:03:03 +0800
> Because those following if conditions will not be matched.
>
> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-27 21:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-27 9:03 [PATCH net-next] neigh: directly goto out after setting nud_state to NUD_FAILED Duan Jiong
2014-02-27 21:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).