From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: Possible fix Date: Thu, 27 Feb 2014 17:24:30 +0100 Message-ID: <530F66BE.4010401@redhat.com> References: <20140227151954.GA30946@redhat.com> <1393517857-11842-1-git-send-email-nikolay@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Nikolay Aleksandrov , Dave Jones , Steffen Klassert , Fan Du , "David S. Miller" To: netdev@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38600 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752318AbaB0Q3E (ORCPT ); Thu, 27 Feb 2014 11:29:04 -0500 In-Reply-To: <1393517857-11842-1-git-send-email-nikolay@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On 02/27/2014 05:17 PM, Nikolay Aleksandrov wrote: > Hi, > I'm not familiar with the code but happened to see the bug, could you > try the following patch, I believe it should fix the issue. > > Thanks, > Nik > > [PATCH net] net: af_key: fix sleeping under rcu > > There's a kmalloc with GFP_KERNEL in a helper > (pfkey_sadb2xfrm_user_sec_ctx) used in pfkey_compile_policy which is > called under rcu_read_lock. Adjust pfkey_sadb2xfrm_user_sec_ctx to have > a gfp argument and adjust the users. > > CC: Dave Jones > CC: Steffen Klassert > CC: Fan Du > CC: David S. Miller > > Signed-off-by: Nikolay Aleksandrov > --- > I'm not familiar with this code, but just happen to see the bug. I believe > this patch should take care of it. > I've left the already very long lines. > Actually there isn't a check if uctx is NULL upon return which can happen. This is only a test patch and that check should be added as well. Nik