From: John Fastabend <john.r.fastabend@intel.com>
To: Ding Tianhong <dingtianhong@huawei.com>
Cc: Patrick McHardy <kaber@trash.net>,
"David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net RESEND] vlan: don't allow to add VLAN on VLAN device
Date: Thu, 27 Feb 2014 19:45:59 -0800 [thread overview]
Message-ID: <53100677.2060705@intel.com> (raw)
In-Reply-To: <530FF7BF.4030706@huawei.com>
On 2/27/2014 6:43 PM, Ding Tianhong wrote:
> I run these steps:
>
> modprobe 8021q
> vconfig add eth2 20
> vconfig add eth2.20 20
> ifconfig eth2 xx.xx.xx.xx
>
> then the Call Trace happened:
>
[...]
> ========================================================================
>
> The reason is that if add vlan on vlan dev, the vlan dev will create vlan_info,
> then the notification will let the real dev to run dev_set_rx_mode() and hold
> netif_addr_lock, and then the real dev will call ndo_set_rx_mode(), if the real
> dev is vlan dev, the ndo_set_rx_mode() will hold netif_addr_lock again, so deadlock
> happened.
>
> Don't allow to add vlan on vlan dev to fix this problem.
>
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
> ---
I'm not sure we can just disable stacked vlans. There might be something
using them today and they have worked in the past. Lets try to find a
better fix.
.John
next prev parent reply other threads:[~2014-02-28 3:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 2:43 [PATCH net RESEND] vlan: don't allow to add VLAN on VLAN device Ding Tianhong
2014-02-28 3:45 ` John Fastabend [this message]
2014-02-28 5:26 ` Ding Tianhong
2014-02-28 5:41 ` Florian Fainelli
2014-02-28 6:34 ` Ding Tianhong
2014-03-05 0:10 ` Ben Hutchings
2014-03-05 1:31 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53100677.2060705@intel.com \
--to=john.r.fastabend@intel.com \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).