From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: "David Miller" <davem@davemloft.net>,
sw@simonwunderlich.de, netdev@vger.kernel.org,
"Linus Lüssing" <linus.luessing@c0d3.blue>
Subject: Re: [PATCH 00/10] pull request for net-next: batman-adv 2019-06-27 v2
Date: Fri, 28 Jun 2019 19:01:41 +0200 [thread overview]
Message-ID: <5314018.Pl9QOMrv0R@sven-edge> (raw)
In-Reply-To: <20190628.094905.1673194288384587104.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
On Friday, 28 June 2019 18:49:05 CEST David Miller wrote:
[...]
> I think that when you have the read_lock held, RCU is not necessary in order
> to use __in6_dev_get() but I may be mistaken. Just FYI...
Problem is that the read_lock() can only be used after the __in6_dev_get()
finished sucessfully. Because the read_lock's lock is stored in the inet6_dev
object which was retrieved via __in6_dev_get. And the __in6_dev_get kerneldoc
states [1] that you either have to hold RTNL or RCU (see also the
rcu_dereference_rtnl call inside this function).
So we can only drop the rcu_read_lock when RTNL lock is held . I would guess
now that this is not the case here - Linus' might want to correct me.
Kind regards,
Sven
[1] https://lxr.missinglinkelectronics.com/linux/include/net/addrconf.h#L335
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-06-28 17:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 13:55 [PATCH 00/10] pull request for net-next: batman-adv 2019-06-27 v2 Simon Wunderlich
2019-06-28 13:55 ` [PATCH 01/10] batman-adv: Start new development cycle Simon Wunderlich
2019-06-28 13:55 ` [PATCH 02/10] batman-adv: Fix includes for *_MAX constants Simon Wunderlich
2019-06-28 13:55 ` [PATCH 03/10] batman-adv: Add missing include for atomic functions Simon Wunderlich
2019-06-28 13:55 ` [PATCH 04/10] batman-adv: Use includes instead of fwdecls Simon Wunderlich
2019-06-28 13:55 ` [PATCH 05/10] batman-adv: mcast: shorten multicast tt/tvlv worker spinlock section Simon Wunderlich
2019-06-28 13:56 ` [PATCH 06/10] batman-adv: mcast: collect softif listeners from IP lists instead Simon Wunderlich
2019-06-28 13:56 ` [PATCH 07/10] batman-adv: mcast: avoid redundant multicast TT entries with bridges Simon Wunderlich
2019-06-28 13:56 ` [PATCH 08/10] batman-adv: no need to check return value of debugfs_create functions Simon Wunderlich
2019-06-28 13:56 ` [PATCH 09/10] batman-adv: mcast: detect, distribute and maintain multicast router presence Simon Wunderlich
2019-06-28 13:56 ` [PATCH 10/10] batman-adv: mcast: apply optimizations for routable packets, too Simon Wunderlich
2019-06-28 16:49 ` [PATCH 00/10] pull request for net-next: batman-adv 2019-06-27 v2 David Miller
2019-06-28 17:01 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5314018.Pl9QOMrv0R@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=linus.luessing@c0d3.blue \
--cc=netdev@vger.kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).