netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Claudiu Manoil <claudiu.manoil@freescale.com>
To: <netdev@vger.kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v2 2/2] gianfar: Use Single-Queue polling for "fsl,etsec2"
Date: Fri, 7 Mar 2014 16:50:29 +0200	[thread overview]
Message-ID: <5319DCB5.1080104@freescale.com> (raw)
In-Reply-To: <1394196166-24932-3-git-send-email-claudiu.manoil@freescale.com>

On 3/7/2014 2:42 PM, Claudiu Manoil wrote:
[...]
> @@ -723,9 +737,22 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev)
>   	if (!np || !of_device_is_available(np))
>   		return -ENODEV;
>
> -	/* parse the num of tx and rx queues */
> +	/* parse the num of HW tx and rx queues */
>   	tx_queues = (u32 *)of_get_property(np, "fsl,num_tx_queues", NULL);
> -	num_tx_qs = tx_queues ? *tx_queues : 1;
> +	rx_queues = (u32 *)of_get_property(np, "fsl,num_rx_queues", NULL);
> +
> +	if (priv->mode == SQ_SG_MODE) {

priv->mode not known at this point.
The checks to limit the number of supported queues
are not trivial (awkward DT structure).

I'm recalling this patch for now. Sorry.

  reply	other threads:[~2014-03-07 14:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 12:42 [PATCH net-next v2 0/2] gianfar: Tx timeout issue Claudiu Manoil
2014-03-07 12:42 ` [PATCH net-next v2 1/2] gianfar: Separate out the Tx interrupt handling (Tx NAPI) Claudiu Manoil
2014-03-07 12:42 ` [PATCH net-next v2 2/2] gianfar: Use Single-Queue polling for "fsl,etsec2" Claudiu Manoil
2014-03-07 14:50   ` Claudiu Manoil [this message]
2014-03-10 17:18 ` [PATCH net-next v2 0/2] gianfar: Tx timeout issue David Miller
2014-03-11  8:10   ` Claudiu Manoil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5319DCB5.1080104@freescale.com \
    --to=claudiu.manoil@freescale.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).