From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netlink: switch net_ns only if net is not init_net
Date: Mon, 10 Mar 2014 09:11:24 +0800 [thread overview]
Message-ID: <531D113C.80709@cn.fujitsu.com> (raw)
In-Reply-To: <20140309.190941.472588800498066811.davem@davemloft.net>
On 03/10/2014 07:09 AM, David Miller wrote:
> From: Gu Zheng <guz.fnst@cn.fujitsu.com>
> Date: Fri, 07 Mar 2014 18:47:30 +0800
>
>> Many netlink users create netlink sock in the init_net, and the
>> switching nes_ns(init_net-->net) is needless in this case. So here
>> we add a pre-check to avoid this.
>>
>> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
>
> This check is more appropriately placed into sk_change_net() itself.
Agree. I'll update it soon.
Regards,
Gu
>
next prev parent reply other threads:[~2014-03-10 1:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 10:47 [PATCH] netlink: switch net_ns only if net is not init_net Gu Zheng
2014-03-09 23:09 ` David Miller
2014-03-10 1:11 ` Gu Zheng [this message]
2014-03-10 1:57 ` [PATCH] net: add a pre-check of net_ns in sk_change_net() Gu Zheng
2014-03-10 20:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531D113C.80709@cn.fujitsu.com \
--to=guz.fnst@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).