From: Florian Fainelli <f.fainelli@gmail.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>,
Doug Berger <opendmb@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: phy: remove parameter new_link from phy_mac_interrupt()
Date: Wed, 10 Jan 2018 12:13:59 -0800 [thread overview]
Message-ID: <531f1c67-6791-4ab8-ea24-06951e8821f7@gmail.com> (raw)
In-Reply-To: <80e1b32e-8d8a-a6a2-9e44-65fca8ae9cc2@gmail.com>
On 01/10/2018 12:11 PM, Heiner Kallweit wrote:
> I see two issues with parameter new_link:
>
> 1. It's not needed. See also phy_interrupt(), works w/o this parameter.
> phy_mac_interrupt sets the state to PHY_CHANGELINK and triggers the
> state machine which then calls phy_read_status. And phy_read_status
> updates the link state.
>
> 2. phy_mac_interrupt is used in interrupt context and getting the link
> state may sleep (at least when having to access the PHY registers
> via MDIO bus).
>
> So let's remove it.
This looks fine in premise, but you really need to combine patch 1 and
to 2 to avoid a build failure.
--
Florian
next prev parent reply other threads:[~2018-01-10 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 20:05 [PATCH net-next 0/2] net: phy: remove parameter new_link from phy_mac_interrupt() Heiner Kallweit
2018-01-10 20:11 ` [PATCH net-next 1/2] " Heiner Kallweit
2018-01-10 20:13 ` Florian Fainelli [this message]
2018-01-10 20:11 ` [PATCH net-next 2/2] net: bcmgenet: " Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531f1c67-6791-4ab8-ea24-06951e8821f7@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).