From: Or Gerlitz <ogerlitz@mellanox.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <roland@kernel.org>,
<jackm@dev.mellanox.co.il>, <amirv@mellanox.com>
Subject: Re: [PATCH V1 net-next 3/7] mlx4: In RoCE allow guests to have multiple GIDS
Date: Wed, 12 Mar 2014 10:49:47 +0200 [thread overview]
Message-ID: <53201FAB.3040208@mellanox.com> (raw)
In-Reply-To: <20140312.010052.1153760698053567291.davem@davemloft.net>
On 12/03/2014 07:00, David Miller wrote:
> I hate to be picky like this, but this second function could be improved.
>
> The first function is fine, it's named "get_*" and it really does return
> a value.
>
> But the second one, it's also named "get_*" but it doesn't return the
> stated value. Instead, it assigns it into a structure.
>
> The return value is always zero, so I suggest you make it return void and
> adjust the name. Perhaps "fill_in_real_sgid_index", since that states
> explicitly that the value is "filled in" to the passed ah_attr.
sure, will fix, thanks for spotting this small possible improvement
next prev parent reply other threads:[~2014-03-12 8:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 13:02 [PATCH V1 net-next 0/7] mlx4: Add SRIOV support for RoCE Or Gerlitz
2014-03-11 13:02 ` [PATCH V1 net-next 1/7] mlx4: Adjust QP1 multiplexing for RoCE/SRIOV Or Gerlitz
2014-03-11 13:02 ` [PATCH V1 net-next 2/7] mlx4_core: For RoCE, allow slaves to set the GID entry at that slave's index Or Gerlitz
2014-03-11 19:12 ` Sergei Shtylyov
2014-03-11 20:12 ` Or Gerlitz
2014-03-11 13:02 ` [PATCH V1 net-next 3/7] mlx4: In RoCE allow guests to have multiple GIDS Or Gerlitz
2014-03-12 5:00 ` David Miller
2014-03-12 8:49 ` Or Gerlitz [this message]
2014-03-11 13:02 ` [PATCH V1 net-next 4/7] mlx4: Add ref counting to port MAC table for RoCE Or Gerlitz
2014-03-11 13:02 ` [PATCH V1 net-next 5/7] mlx4: Implement IP based gids support for RoCE/SRIOV Or Gerlitz
2014-03-11 13:02 ` [PATCH V1 net-next 6/7] mlx4_ib: Fix SIDR support of for UD QPs under SRIOV/RoCE Or Gerlitz
2014-03-11 13:02 ` [PATCH V1 net-next 7/7] mlx4: Activate RoCE/SRIOV Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53201FAB.3040208@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=jackm@dev.mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).