From: Ding Tianhong <dingtianhong@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <ben@decadent.org.uk>, <john.r.fastabend@intel.com>,
<kaber@trash.net>, <netdev@vger.kernel.org>,
<f.fainelli@gmail.com>
Subject: Re: [PATCH net v2] vlan: Fix lockdep warning when vlan dev handle notification
Date: Fri, 14 Mar 2014 09:43:15 +0800 [thread overview]
Message-ID: <53225EB3.3030605@huawei.com> (raw)
In-Reply-To: <20140313.155230.2146893995359373637.davem@davemloft.net>
On 2014/3/14 3:52, David Miller wrote:
> From: Ding Tianhong <dingtianhong@huawei.com>
> Date: Thu, 13 Mar 2014 10:22:18 +0800
>
>> v1->v2: Convert the vlan_netdev_addr_lock_key to an array of eight elements, which
>> could support to add 8 vlan id on a same vlan dev, I think it is enough for current
>> scene, because a netdev's name is limited to IFNAMSIZ which could not hold 8 vlan id,
>> and the vlan dev would not meet the same class key with its real dev.
>>
>> The new function vlan_dev_get_lockdep_subkey() will return the subkey and make the vlan
>> dev could get a suitable class key.
>
> I still am not happy with this solution, unfortunately. Although I do
> appreciate your efforts.
>
> I'm going to do some more research into this issue and try to give you
> some more constructive, meaningful, feedback.
>
> Thanks.
>
>
Thanks for any constructive feedback.
Regards
Ding
next prev parent reply other threads:[~2014-03-14 1:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 2:22 [PATCH net v2] vlan: Fix lockdep warning when vlan dev handle notification Ding Tianhong
2014-03-13 19:52 ` David Miller
2014-03-14 1:43 ` Ding Tianhong [this message]
2014-03-15 2:02 ` David Miller
2014-03-17 3:08 ` Ding Tianhong
2014-03-27 17:06 ` David Miller
2014-03-28 1:13 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53225EB3.3030605@huawei.com \
--to=dingtianhong@huawei.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).