From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Ben Dooks <ben.dooks@codethink.co.uk>
Cc: netdev <netdev@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] micrel: fix masking off LED bits
Date: Wed, 19 Mar 2014 22:35:30 +0300 [thread overview]
Message-ID: <5329F182.6090206@cogentembedded.com> (raw)
In-Reply-To: <CAGVrzcZd6rx0dbAdtqk3pbjuTVr4vwFqsRJxgc+dTQ0imnY57Q@mail.gmail.com>
Hello.
On 03/19/2014 07:21 PM, Florian Fainelli wrote:
>>> Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made
>>> the
>>> obvious mistake when masking off the LED mode bits: forgot to do a
>>> logical NOT
>>> to the mask with which it ANDs the register value, so that unrelated bits
>>> are
>>> cleared instead.
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Acked-by: Ben Dooks <ben.dooks@codethink.co.uk>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Oh, sorry for not CCing you -- I forgot that phylib is now maintained.
WBR, Sergei
next prev parent reply other threads:[~2014-03-19 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 23:58 [PATCH] micrel: fix masking off LED bits Sergei Shtylyov
2014-03-18 23:27 ` Laurent Pinchart
2014-03-19 8:12 ` Ben Dooks
2014-03-19 16:21 ` Florian Fainelli
2014-03-19 19:35 ` Sergei Shtylyov [this message]
2014-03-19 21:42 ` David Miller
2014-03-20 18:44 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5329F182.6090206@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ben.dooks@codethink.co.uk \
--cc=f.fainelli@gmail.com \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).