From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wangyufen <wangyufen@huawei.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/3] ipv6: fix checkpatch errors of foo
Date: Wed, 26 Mar 2014 17:45:26 +0400 [thread overview]
Message-ID: <5332D9F6.6030405@cogentembedded.com> (raw)
In-Reply-To: <1395801446-8700-4-git-send-email-wangyufen@huawei.com>
Hello.
On 26-03-2014 6:37, Wangyufen wrote:
> From: Wang Yufen <wangyufen@huawei.com>
Unfortunately, your subject doesn't make much sense (I didn't notice it in
the first review).
> ERROR: "(foo*)" should be "(foo *)"
> ERROR: "foo * bar" should be "foo *bar"
Actually, it's the same space issues patch #1 fixes, so it's worth merging
them...
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
WBR, Sergei
prev parent reply other threads:[~2014-03-26 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 2:37 [PATCH net-next v2 0/3] ipv6: fix checkpatch errors and warnings Wangyufen
2014-03-26 2:37 ` [PATCH net-next v2 1/3] ipv6: fix checkpatch errors comments and space Wangyufen
2014-03-26 2:37 ` [PATCH net-next v2 2/3] ipv6: fix checkpatch errors of brace and trailing statements Wangyufen
2014-03-26 2:37 ` [PATCH net-next v2 3/3] ipv6: fix checkpatch errors of foo Wangyufen
2014-03-26 13:45 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5332D9F6.6030405@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wangyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).