public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "pupilla@libero.it" <pupilla@libero.it>
To: David Miller <davem@davemloft.net>, <dsa@cumulusnetworks.com>
Cc: <netdev@vger.kernel.org>
Subject: R: Re: [PATCH net] lwtunnel: valid encap attr check should return 0 when lwtunnel is disabled
Date: Thu, 9 Feb 2017 09:48:58 +0100 (CET)	[thread overview]
Message-ID: <533381532.379531486630138912.JavaMail.httpd@webmail-35.iol.local> (raw)

David Miller wrote:

>Data: 8-feb-2017 18.55
>A: <dsa@cumulusnetworks.com>
>Cc: <netdev@vger.kernel.org>, <pupilla@libero.it>
>Ogg: Re: [PATCH net] lwtunnel: valid encap attr check should return 0 when 
lwtunnel is disabled
>
>From: David Ahern <dsa@cumulusnetworks.com>
>Date: Wed,  8 Feb 2017 09:29:00 -0800
>
>> An error was reported upgrading to 4.9.8:
>>     root@Typhoon:~# ip route add default table 210 nexthop dev eth0 via 
10.68.64.1
>>     weight 1 nexthop dev eth0 via 10.68.64.2 weight 1
>>     RTNETLINK answers: Operation not supported
>> 
>> The problem occurs when CONFIG_LWTUNNEL is not enabled and a multipath
>> route is submitted.
>> 
>> The point of lwtunnel_valid_encap_type_attr is catch modules that
>> need to be loaded before any references are taken with rntl held. With
>> CONFIG_LWTUNNEL disabled, there will be no modules to load so the
>> lwtunnel_valid_encap_type_attr stub should just return 0.
>> 
>> Fixes: 9ed59592e3e3 ("lwtunnel: fix autoload of lwt modules")
>> Reported-by: pupilla@libero.it
>> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
>
>Applied and queued up for -stable, thanks for fixing this so quickly David.

Thanks everybody. I have applied the patch to linux-4.9.8 and all is fine.

Thanks again.

Marco

                 reply	other threads:[~2017-02-09  8:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533381532.379531486630138912.JavaMail.httpd@webmail-35.iol.local \
    --to=pupilla@libero.it \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox