From: wangyufen <wangyufen@huawei.com>
To: <davem@davemloft.net>, <netdev@vger.kernel.org>,
Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Subject: Re: [PATCH net-next v3 2/2] net: tcp_ipv6 policy route issue
Date: Thu, 27 Mar 2014 10:00:34 +0800 [thread overview]
Message-ID: <53338642.1060405@huawei.com> (raw)
In-Reply-To: <20140326070548.GF22086@order.stressinduktion.org>
On 2014/3/26 15:05, Hannes Frederic Sowa wrote:
> On Mon, Mar 24, 2014 at 02:25:22PM +0800, Wangyufen wrote:
>> From: Wang Yufen <wangyufen@huawei.com>
>>
>> The issue raises when adding policy route, specify a particular
>> NIC as oif, the policy route did not take effect. The reason is
>> that fl6.oif is not set and route map failed. From the
>> tcp_v6_send_response function, if the binding address is linklocal,
>> fl6.oif is set, but not for global address.
>>
>> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
>
> But this looks like a bug to me, so maybe this is something for net
> inclusion.
I checked the commit log, I think, changes to ipv6 was incompleted in
commit 4c67525849e0b7f4bd4fab leded to this issue .
In tcp_v6_send_response, fl6.oif can't be directly set to iif for global
address, but it should not be 0.
>
> Thanks,
>
> Hannes
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2014-03-27 2:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 6:25 [PATCH net-next v3 1/2] net: tcp_ipv6 do some cleanup Wangyufen
2014-03-24 6:25 ` [PATCH net-next v3 2/2] net: tcp_ipv6 policy route issue Wangyufen
2014-03-26 7:05 ` Hannes Frederic Sowa
2014-03-27 2:00 ` wangyufen [this message]
2014-03-27 5:32 ` Hannes Frederic Sowa
2014-03-28 1:11 ` wangyufen
2014-03-26 19:42 ` [PATCH net-next v3 1/2] net: tcp_ipv6 do some cleanup David Miller
2014-03-26 20:40 ` Joe Perches
2014-03-26 21:07 ` David Miller
2014-03-27 1:18 ` wangyufen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53338642.1060405@huawei.com \
--to=wangyufen@huawei.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).