From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48FD4C606BD for ; Mon, 8 Jul 2019 18:13:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22739205ED for ; Mon, 8 Jul 2019 18:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733259AbfGHSND (ORCPT ); Mon, 8 Jul 2019 14:13:03 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:46688 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728624AbfGHSND (ORCPT ); Mon, 8 Jul 2019 14:13:03 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hkY8D-0004Kj-3a; Mon, 08 Jul 2019 20:12:53 +0200 Message-ID: <533462cfc4cf42be9886078a1d8b450d07cbbf6e.camel@sipsolutions.net> Subject: Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface From: Johannes Berg To: Michal Kubecek , netdev@vger.kernel.org Cc: Jiri Pirko , David Miller , Jakub Kicinski , Andrew Lunn , Florian Fainelli , John Linville , Stephen Hemminger , linux-kernel@vger.kernel.org Date: Mon, 08 Jul 2019 20:12:50 +0200 In-Reply-To: <20190708172729.GC24474@unicorn.suse.cz> References: <20190702122521.GN2250@nanopsycho> <20190702145241.GD20101@unicorn.suse.cz> <20190703084151.GR2250@nanopsycho> <20190708172729.GC24474@unicorn.suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-3.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 2019-07-08 at 19:27 +0200, Michal Kubecek wrote: > > Second reason is that with 8-bit genetlink command/message id, the space > is not as infinite as it might seem. FWIW, there isn't really any good reason for this, we have like 16 reserved bits in the genl header. OTOH, having a LOT of ops will certainly cost space in the kernel image... johannes