From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>, netdev@vger.kernel.org
Cc: linux-sh@vger.kernel.org, magnus.damm@opensource.se,
nobuhiro.iwamatsu.yj@renesas.com
Subject: Re: [RFC] sh_eth: use RNC mode for R8A7790
Date: Fri, 28 Mar 2014 23:38:31 +0300 [thread overview]
Message-ID: <5335DDC7.8040400@cogentembedded.com> (raw)
In-Reply-To: <1396025185-7911-1-git-send-email-ben.dooks@codethink.co.uk>
Hello.
On 03/28/2014 07:46 PM, Ben Dooks wrote:
> The current behaviour of the sh_eth driver is not to use the RNC bit
> for the receive ring. This means that every packet recieved is not only
> generating an IRQ but it also stops the receive ring DMA as well until
> the driver re-enables it after unloading the packet.
> This means that a number of the following errors are generated due to
> the receive packet FIFO overflowing due to nowhere to put packets:
> net eth0: Receive FIFO Overflow
> Setting the RMCR_RNC configuration has so far been tested with an NFS
> root filesystem and the driver has not failed yet. It is not yet known
> why this is not set for R8A779x operation
The reason is simple: it's not set on almost all 100 Mbs devices except
SH7757 (and most recently added R7S72100), so this was a matter of copy-paste.
I've had setting this bit on at least R-Car devices on my aganda for some time
but couldn't get to it yet.
> (Feedback on this issue or other testing is welcome)
OK, I'll try it with netperf UDP test known to generate handful of the
aforementioned errors, when I have time.
WBR, Sergei
next prev parent reply other threads:[~2014-03-28 19:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 16:46 [RFC] sh_eth: use RNC mode for R8A7790 Ben Dooks
2014-03-28 20:38 ` Sergei Shtylyov [this message]
2014-03-28 20:13 ` Ben Dooks
2014-04-14 12:47 ` Ben Dooks
2014-04-14 16:35 ` Geert Uytterhoeven
2014-04-14 16:48 ` Geert Uytterhoeven
2014-04-25 23:54 ` Sergei Shtylyov
2014-04-25 23:55 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5335DDC7.8040400@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@opensource.se \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).