* [PATCH] rtl8187: fix use after free on failure path in rtl8187_probe()
@ 2014-03-28 20:26 Alexey Khoroshilov
2014-03-30 21:31 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Khoroshilov @ 2014-03-28 20:26 UTC (permalink / raw)
To: Herton Ronaldo Krzesinski, Hin-Tak Leung, Larry Finger
Cc: Alexey Khoroshilov, John W. Linville,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
ldv-project-tpLiQldItUH5n4uC9ZG1Ww
If allocation of io_dmabuf fails, rtl8187_probe() calls usb_put_dev(udev)
while usb_get_dev(udev) is not called yet. As a result refcnt is decremented
incorrectly and usb_dev can be used after memory deallocation.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov-ufN2psIa012HXe+LvDLADg@public.gmane.org>
---
drivers/net/wireless/rtl818x/rtl8187/dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtl818x/rtl8187/dev.c b/drivers/net/wireless/rtl818x/rtl8187/dev.c
index fd78df813a85..d7f540a9dc9b 100644
--- a/drivers/net/wireless/rtl818x/rtl8187/dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8187/dev.c
@@ -1636,10 +1636,10 @@ static int rtl8187_probe(struct usb_interface *intf,
err_free_dmabuf:
kfree(priv->io_dmabuf);
- err_free_dev:
- ieee80211_free_hw(dev);
usb_set_intfdata(intf, NULL);
usb_put_dev(udev);
+ err_free_dev:
+ ieee80211_free_hw(dev);
return err;
}
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtl8187: fix use after free on failure path in rtl8187_probe()
2014-03-28 20:26 [PATCH] rtl8187: fix use after free on failure path in rtl8187_probe() Alexey Khoroshilov
@ 2014-03-30 21:31 ` Larry Finger
0 siblings, 0 replies; 3+ messages in thread
From: Larry Finger @ 2014-03-30 21:31 UTC (permalink / raw)
To: Alexey Khoroshilov, Herton Ronaldo Krzesinski, Hin-Tak Leung
Cc: John W. Linville, linux-wireless, netdev, linux-kernel,
ldv-project
On 03/28/2014 03:26 PM, Alexey Khoroshilov wrote:
> If allocation of io_dmabuf fails, rtl8187_probe() calls usb_put_dev(udev)
> while usb_get_dev(udev) is not called yet. As a result refcnt is decremented
> incorrectly and usb_dev can be used after memory deallocation.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
> drivers/net/wireless/rtl818x/rtl8187/dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rtl818x/rtl8187/dev.c b/drivers/net/wireless/rtl818x/rtl8187/dev.c
> index fd78df813a85..d7f540a9dc9b 100644
> --- a/drivers/net/wireless/rtl818x/rtl8187/dev.c
> +++ b/drivers/net/wireless/rtl818x/rtl8187/dev.c
> @@ -1636,10 +1636,10 @@ static int rtl8187_probe(struct usb_interface *intf,
>
> err_free_dmabuf:
> kfree(priv->io_dmabuf);
> - err_free_dev:
> - ieee80211_free_hw(dev);
> usb_set_intfdata(intf, NULL);
> usb_put_dev(udev);
> + err_free_dev:
> + ieee80211_free_hw(dev);
> return err;
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtl8187: fix use after free on failure path in rtl8187_probe()
@ 2014-04-08 0:12 Hin-Tak Leung
0 siblings, 0 replies; 3+ messages in thread
From: Hin-Tak Leung @ 2014-04-08 0:12 UTC (permalink / raw)
To: larry.finger, khoroshilov, herton
Cc: linville, linux-wireless, netdev, linux-kernel, ldv-project
------------------------------
On Sun, Mar 30, 2014 10:31 PM BST Larry Finger wrote:
>On 03/28/2014 03:26 PM, Alexey Khoroshilov wrote:
> If allocation of io_dmabuf fails, rtl8187_probe() calls usb_put_dev(udev)
> while usb_get_dev(udev) is not called yet. As a result refcnt is decremented
> incorrectly and usb_dev can be used after memory deallocation.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
>
>Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
>
>Thanks,
>
>Larry
Acked-by: Hin-Tak Leung <htl10@users.sourceforge.net>
Hin-Tak
>
> drivers/net/wireless/rtl818x/rtl8187/dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rtl818x/rtl8187/dev.c b/drivers/net/wireless/rtl818x/rtl8187/dev.c
> index fd78df813a85..d7f540a9dc9b 100644
> --- a/drivers/net/wireless/rtl818x/rtl8187/dev.c
> +++ b/drivers/net/wireless/rtl818x/rtl8187/dev.c
> @@ -1636,10 +1636,10 @@ static int rtl8187_probe(struct usb_interface *intf,
>
> err_free_dmabuf:
> kfree(priv->io_dmabuf);
> - err_free_dev:
> - ieee80211_free_hw(dev);
> usb_set_intfdata(intf, NULL);
> usb_put_dev(udev);
> + err_free_dev:
> + ieee80211_free_hw(dev);
> return err;
> }
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-08 0:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-28 20:26 [PATCH] rtl8187: fix use after free on failure path in rtl8187_probe() Alexey Khoroshilov
2014-03-30 21:31 ` Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2014-04-08 0:12 Hin-Tak Leung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).