* [PATCH] net/phy: Remove return value for a void function
@ 2014-04-01 14:22 Shruti
2014-04-01 14:33 ` Emil Medve
0 siblings, 1 reply; 9+ messages in thread
From: Shruti @ 2014-04-01 14:22 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, emmedve1, Shruti Kanetkar
From: Shruti Kanetkar <Shruti@Freescale.com>
Change-Id: I03747d79beb1ef3a9e7fc8a11495196eabbed33f
Signed-off-by: Shruti Kanetkar <Shruti@Freescale.com>
Reviewed-on: http://git.am.freescale.net:8181/8914
Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com>
Reviewed-by: Shruti Kanetkar <Shruti@freescale.com>
---
drivers/net/phy/vitesse.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c
index 14372c6..1f2f060 100644
--- a/drivers/net/phy/vitesse.c
+++ b/drivers/net/phy/vitesse.c
@@ -319,8 +319,8 @@ static int __init vsc82xx_init(void)
static void __exit vsc82xx_exit(void)
{
- return phy_drivers_unregister(vsc82xx_driver,
- ARRAY_SIZE(vsc82xx_driver));
+ phy_drivers_unregister(vsc82xx_driver,
+ ARRAY_SIZE(vsc82xx_driver));
}
module_init(vsc82xx_init);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] net/phy: Remove return value for a void function
2014-04-01 14:22 [PATCH] net/phy: Remove return value for a void function Shruti
@ 2014-04-01 14:33 ` Emil Medve
2014-04-01 17:26 ` Sergei Shtylyov
0 siblings, 1 reply; 9+ messages in thread
From: Emil Medve @ 2014-04-01 14:33 UTC (permalink / raw)
To: Shruti, f.fainelli; +Cc: netdev
Hello Shruti,
On 04/01/2014 09:22 AM, Shruti@Freescale.com wrote:
> From: Shruti Kanetkar <Shruti@Freescale.com>
>
> Change-Id: I03747d79beb1ef3a9e7fc8a11495196eabbed33f
> Signed-off-by: Shruti Kanetkar <Shruti@Freescale.com>
> Reviewed-on: http://git.am.freescale.net:8181/8914
> Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com>
> Reviewed-by: Shruti Kanetkar <Shruti@freescale.com>
Please remove the internal Gerrit meta and re-send
Cheers,
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] net/phy: Remove return value for a void function
@ 2014-04-01 14:44 Shruti
2014-04-01 17:47 ` Florian Fainelli
2014-04-01 18:04 ` Joe Perches
0 siblings, 2 replies; 9+ messages in thread
From: Shruti @ 2014-04-01 14:44 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, emmedve1, Shruti Kanetkar
From: Shruti Kanetkar <Shruti@Freescale.com>
Signed-off-by: Shruti Kanetkar <Shruti@Freescale.com>
---
drivers/net/phy/vitesse.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c
index 14372c6..1f2f060 100644
--- a/drivers/net/phy/vitesse.c
+++ b/drivers/net/phy/vitesse.c
@@ -319,8 +319,8 @@ static int __init vsc82xx_init(void)
static void __exit vsc82xx_exit(void)
{
- return phy_drivers_unregister(vsc82xx_driver,
- ARRAY_SIZE(vsc82xx_driver));
+ phy_drivers_unregister(vsc82xx_driver,
+ ARRAY_SIZE(vsc82xx_driver));
}
module_init(vsc82xx_init);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] net/phy: Remove return value for a void function
2014-04-01 14:33 ` Emil Medve
@ 2014-04-01 17:26 ` Sergei Shtylyov
0 siblings, 0 replies; 9+ messages in thread
From: Sergei Shtylyov @ 2014-04-01 17:26 UTC (permalink / raw)
To: Emil Medve, Shruti, f.fainelli; +Cc: netdev
Hello.
On 04/01/2014 06:33 PM, Emil Medve wrote:
>> From: Shruti Kanetkar <Shruti@Freescale.com>
>> Change-Id: I03747d79beb1ef3a9e7fc8a11495196eabbed33f
>> Signed-off-by: Shruti Kanetkar <Shruti@Freescale.com>
>> Reviewed-on: http://git.am.freescale.net:8181/8914
>> Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com>
>> Reviewed-by: Shruti Kanetkar <Shruti@freescale.com>
What's that, self-review? :-)
> Please remove the internal Gerrit meta and re-send
Change-Id is OK for networking patches, DaveM has approved its use.
Reviewed-on is something new though...
WBR, Sergei
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net/phy: Remove return value for a void function
2014-04-01 14:44 Shruti
@ 2014-04-01 17:47 ` Florian Fainelli
2014-04-01 18:04 ` Joe Perches
1 sibling, 0 replies; 9+ messages in thread
From: Florian Fainelli @ 2014-04-01 17:47 UTC (permalink / raw)
To: Shruti; +Cc: netdev, emmedve1
2014-04-01 7:44 GMT-07:00 <Shruti@freescale.com>:
> From: Shruti Kanetkar <Shruti@Freescale.com>
>
> Signed-off-by: Shruti Kanetkar <Shruti@Freescale.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/net/phy/vitesse.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c
> index 14372c6..1f2f060 100644
> --- a/drivers/net/phy/vitesse.c
> +++ b/drivers/net/phy/vitesse.c
> @@ -319,8 +319,8 @@ static int __init vsc82xx_init(void)
>
> static void __exit vsc82xx_exit(void)
> {
> - return phy_drivers_unregister(vsc82xx_driver,
> - ARRAY_SIZE(vsc82xx_driver));
> + phy_drivers_unregister(vsc82xx_driver,
> + ARRAY_SIZE(vsc82xx_driver));
> }
>
> module_init(vsc82xx_init);
> --
> 1.8.3.1
>
>
--
Florian
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net/phy: Remove return value for a void function
2014-04-01 14:44 Shruti
2014-04-01 17:47 ` Florian Fainelli
@ 2014-04-01 18:04 ` Joe Perches
2014-04-01 19:53 ` Shruti Kanetkar
1 sibling, 1 reply; 9+ messages in thread
From: Joe Perches @ 2014-04-01 18:04 UTC (permalink / raw)
To: Shruti; +Cc: f.fainelli, netdev, emmedve1
Here's a spatch script for this:
$ cat void_return.cocci
@@
identifier func;
expression S;
@@
void func(...) {
...
if (...)
- return S;
+ { S; return; }
...
}
@@
identifier func;
expression S;
@@
void func(...) {
...
if (...) {
...
- return S;
+ S;
}
...
}
@@
identifier func;
expression S;
@@
void func(...) {
...
- return S;
+ S;
}
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] net/phy: Remove return value for a void function
2014-04-01 18:04 ` Joe Perches
@ 2014-04-01 19:53 ` Shruti Kanetkar
2014-04-01 19:59 ` Florian Fainelli
0 siblings, 1 reply; 9+ messages in thread
From: Shruti Kanetkar @ 2014-04-01 19:53 UTC (permalink / raw)
To: Joe Perches; +Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, Emilian Medve
Hello Joe,
Thank you for sharing the script.
I shall give it a try and credit you for the script.
> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Tuesday, April 01, 2014 1:04 PM
> To: Kanetkar Shruti-B44454
> Cc: f.fainelli@gmail.com; netdev@vger.kernel.org; Medve Emilian-EMMEDVE1
> Subject: Re: [PATCH] net/phy: Remove return value for a void function
>
> Here's a spatch script for this:
>
> $ cat void_return.cocci
> @@
> identifier func;
> expression S;
> @@
> void func(...) {
> ...
> if (...)
> - return S;
> + { S; return; }
> ...
> }
>
> @@
> identifier func;
> expression S;
> @@
> void func(...) {
> ...
> if (...) {
> ...
> - return S;
> + S;
> }
> ...
> }
>
> @@
> identifier func;
> expression S;
> @@
> void func(...) {
> ...
> - return S;
> + S;
> }
>
>
>
Regards,
Shruti
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net/phy: Remove return value for a void function
2014-04-01 19:53 ` Shruti Kanetkar
@ 2014-04-01 19:59 ` Florian Fainelli
2014-04-01 20:03 ` Shruti Kanetkar
0 siblings, 1 reply; 9+ messages in thread
From: Florian Fainelli @ 2014-04-01 19:59 UTC (permalink / raw)
To: Shruti Kanetkar; +Cc: Joe Perches, netdev@vger.kernel.org, Emilian Medve
Hi Shruti,
2014-04-01 12:53 GMT-07:00 Shruti Kanetkar <Shruti@freescale.com>:
> Hello Joe,
>
> Thank you for sharing the script.
> I shall give it a try and credit you for the script.
Can you run this spatch throughout the drivers/net/phy/ files to begin
with and see what interesting results it produces?
Thanks!
>
>> -----Original Message-----
>> From: Joe Perches [mailto:joe@perches.com]
>> Sent: Tuesday, April 01, 2014 1:04 PM
>> To: Kanetkar Shruti-B44454
>> Cc: f.fainelli@gmail.com; netdev@vger.kernel.org; Medve Emilian-EMMEDVE1
>> Subject: Re: [PATCH] net/phy: Remove return value for a void function
>>
>> Here's a spatch script for this:
>>
>> $ cat void_return.cocci
>> @@
>> identifier func;
>> expression S;
>> @@
>> void func(...) {
>> ...
>> if (...)
>> - return S;
>> + { S; return; }
>> ...
>> }
>>
>> @@
>> identifier func;
>> expression S;
>> @@
>> void func(...) {
>> ...
>> if (...) {
>> ...
>> - return S;
>> + S;
>> }
>> ...
>> }
>>
>> @@
>> identifier func;
>> expression S;
>> @@
>> void func(...) {
>> ...
>> - return S;
>> + S;
>> }
>>
>>
>>
>
> Regards,
> Shruti
--
Florian
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] net/phy: Remove return value for a void function
2014-04-01 19:59 ` Florian Fainelli
@ 2014-04-01 20:03 ` Shruti Kanetkar
0 siblings, 0 replies; 9+ messages in thread
From: Shruti Kanetkar @ 2014-04-01 20:03 UTC (permalink / raw)
To: Florian Fainelli; +Cc: Joe Perches, netdev@vger.kernel.org, Emilian Medve
Hello Florian,
> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@gmail.com]
> Sent: Tuesday, April 01, 2014 3:00 PM
> To: Kanetkar Shruti-B44454
> Cc: Joe Perches; netdev@vger.kernel.org; Medve Emilian-EMMEDVE1
> Subject: Re: [PATCH] net/phy: Remove return value for a void function
>
> Hi Shruti,
>
> 2014-04-01 12:53 GMT-07:00 Shruti Kanetkar <Shruti@freescale.com>:
> > Hello Joe,
> >
> > Thank you for sharing the script.
> > I shall give it a try and credit you for the script.
>
> Can you run this spatch throughout the drivers/net/phy/ files to begin
> with and see what interesting results it produces?
>
Yes, I shall definitely try that.
> Thanks!
>
> >
> >> -----Original Message-----
> >> From: Joe Perches [mailto:joe@perches.com]
> >> Sent: Tuesday, April 01, 2014 1:04 PM
> >> To: Kanetkar Shruti-B44454
> >> Cc: f.fainelli@gmail.com; netdev@vger.kernel.org; Medve Emilian-
> EMMEDVE1
> >> Subject: Re: [PATCH] net/phy: Remove return value for a void function
> >>
> >> Here's a spatch script for this:
> >>
> >> $ cat void_return.cocci
> >> @@
> >> identifier func;
> >> expression S;
> >> @@
> >> void func(...) {
> >> ...
> >> if (...)
> >> - return S;
> >> + { S; return; }
> >> ...
> >> }
> >>
> >> @@
> >> identifier func;
> >> expression S;
> >> @@
> >> void func(...) {
> >> ...
> >> if (...) {
> >> ...
> >> - return S;
> >> + S;
> >> }
> >> ...
> >> }
> >>
> >> @@
> >> identifier func;
> >> expression S;
> >> @@
> >> void func(...) {
> >> ...
> >> - return S;
> >> + S;
> >> }
> >>
> >>
> >>
> >
> > Regards,
> > Shruti
>
>
>
> --
> Florian
>
Regards,
Shruti
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-04-01 20:10 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-01 14:22 [PATCH] net/phy: Remove return value for a void function Shruti
2014-04-01 14:33 ` Emil Medve
2014-04-01 17:26 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2014-04-01 14:44 Shruti
2014-04-01 17:47 ` Florian Fainelli
2014-04-01 18:04 ` Joe Perches
2014-04-01 19:53 ` Shruti Kanetkar
2014-04-01 19:59 ` Florian Fainelli
2014-04-01 20:03 ` Shruti Kanetkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).