From: Daniel Borkmann <dborkman@redhat.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
Paul Mundt <lethal@linux-sh.org>,
Fengguang Wu <fengguang.wu@intel.com>,
linux-sh@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] sh: add missing fpscr_values
Date: Wed, 02 Apr 2014 09:04:30 +0200 [thread overview]
Message-ID: <533BB67E.4030803@redhat.com> (raw)
In-Reply-To: <1396407244-26771-1-git-send-email-ast@plumgrid.com>
On 04/02/2014 04:54 AM, Alexei Starovoitov wrote:
> GCC on SuperH for the following program:
> int foo(int i)
> {
> static const void *table[2] = {
> [0] = &&label1,
> [1] = &&label2,
> };
> goto *table[i & 1];
>
> label1:
> return 1;
> label2:
> return 2;
> }
> generates code:
> mov.l .L9,r1
> mov #1,r0
> rts
> lds.l @r1+,fpscr
> .L9:
> .long __fpscr_values+4
>
> so kernel has to provide body of fpscr_values just like glibc does
>
> Fixes: bd4cf0ed331a ("net: filter: rework/optimize internal BPF interpreter's instruction set")
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
> Cc: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Daniel Borkmann <dborkman@redhat.com>
next prev parent reply other threads:[~2014-04-02 7:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 2:54 [PATCH net-next] sh: add missing fpscr_values Alexei Starovoitov
2014-04-02 7:04 ` Daniel Borkmann [this message]
2014-04-02 7:38 ` Geert Uytterhoeven
2014-04-02 10:52 ` Geert Uytterhoeven
2014-04-02 12:47 ` David Miller
2014-04-02 16:09 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533BB67E.4030803@redhat.com \
--to=dborkman@redhat.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).