From: Claudiu Manoil <claudiu.manoil@freescale.com>
To: <roy.qing.li@gmail.com>, <netdev@vger.kernel.org>
Cc: <Yanjun.Zhu@windriver.com>
Subject: Re: [PATCH] Documentation: document the gianfar tx vlan offload issue
Date: Fri, 4 Apr 2014 10:10:59 +0300 [thread overview]
Message-ID: <533E5B03.2050801@freescale.com> (raw)
In-Reply-To: <533E5A19.6060701@freescale.com>
On 4/4/2014 10:07 AM, Claudiu Manoil wrote:
> On 4/4/2014 6:04 AM, roy.qing.li@gmail.com wrote:
>> From: Li RongQing <roy.qing.li@gmail.com>
>>
>> The commit b852b72087[gianfar: fix bug caused by 87c288c6e9] and
>> e2c53be223
>> [gianfar: fix default tx vlan offload feature flag] disabled tx vlan
>> offload
>> from dev->feature, since enabling vlan tag insertion leads to unusable
>> connections on some configurations.
>>
>> But this feature is in dev->hw_feature still, and a user can enable it by
>> "ethtool", so document the tx vlan offload issue.
>>
>> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
>> Signed-off-by: Zhu Yanjun <Yanjun.Zhu@windriver.com>
>> Cc: Claudiu Manoil <claudiu.manoil@freescale.com>
>> ---
>> Documentation/networking/gianfar.txt | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/networking/gianfar.txt
>> b/Documentation/networking/gianfar.txt
>> index ad474ea..2d3dbe6 100644
>> --- a/Documentation/networking/gianfar.txt
>> +++ b/Documentation/networking/gianfar.txt
>> @@ -51,6 +51,18 @@ configuring VLANs. The gianfar driver supports
>> hardware insertion and
>> extraction of VLAN headers, but not filtering. Filtering will be
>> done by the kernel.
>> +But if tx vlan tag hardware insertion is enabled, and a vlan-device is
>> +created, the physical device which vlan device is on will be unable to
>> +work, like:
>> +
>> + $ethtool -K eth0 tx-vlan-stag-hw-insert on
>> + $ifconfig eth0 192.168.1.13/24 up
>> +
>> + $vconfig add eth0 4091
>> + $ifconfig eth0.4091 10.1.1.13/24 up
>> +eth0.4091 can work, but eth0 can not work, since eth0 sends the insane
>> +packets out.
>> +
> I don't really like this, this is hardly a technical explanation.
> ("insane packets"?)
> Please have a look at the HW reference manual. There you have the
> description
> of the VLAN extraction feature (see VLEX).
>
And VLAN insertion (VLINS) as well, for that matter.
next prev parent reply other threads:[~2014-04-04 7:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 3:04 [PATCH] Documentation: document the gianfar tx vlan offload issue roy.qing.li
2014-04-04 3:07 ` yzhu1
2014-04-04 7:07 ` Claudiu Manoil
2014-04-04 7:10 ` Claudiu Manoil [this message]
2014-04-04 7:39 ` Li RongQing
2014-04-04 13:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533E5B03.2050801@freescale.com \
--to=claudiu.manoil@freescale.com \
--cc=Yanjun.Zhu@windriver.com \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).