netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: roy.qing.li@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: recompute the array size
Date: Fri, 04 Apr 2014 16:34:00 +0400	[thread overview]
Message-ID: <533EA6B8.9020007@cogentembedded.com> (raw)
In-Reply-To: <1396594286-21788-1-git-send-email-roy.qing.li@gmail.com>

Hello.

On 04-04-2014 10:51, roy.qing.li@gmail.com wrote:

> From: Li RongQing <roy.qing.li@gmail.com>

> recompute the array size to kill the warning:
>   net/ipv6/xfrm6_state.c:66:26: error: cannot size expression

> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> ---
>   net/ipv6/xfrm6_state.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/net/ipv6/xfrm6_state.c b/net/ipv6/xfrm6_state.c
> index 3fc9701..9e08572 100644
> --- a/net/ipv6/xfrm6_state.c
> +++ b/net/ipv6/xfrm6_state.c
> @@ -63,7 +63,7 @@ __xfrm6_sort(void **dst, void **src, int n, int (*cmp)(void *p), int maxclass)
>   	int class[XFRM_MAX_DEPTH];
>   	int count[maxclass];
>
> -	memset(count, 0, sizeof(count));
> +	memset(count, 0, sizeof(int)*maxclass);

    Please insert spaces before and after *.

WBR, Sergei

  reply	other threads:[~2014-04-04 12:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04  6:51 [PATCH net-next] ipv6: recompute the array size roy.qing.li
2014-04-04 12:34 ` Sergei Shtylyov [this message]
2014-04-04 12:52 ` Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533EA6B8.9020007@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=netdev@vger.kernel.org \
    --cc=roy.qing.li@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).