netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ilya V. Matveychikov" <i.matveychikov@securitycode.ru>
To: David Miller <davem@davemloft.net>, <matvejchikov@gmail.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH] veth: keep peers MTU values synchronized
Date: Fri, 4 Apr 2014 18:42:29 +0400	[thread overview]
Message-ID: <533EC4D5.50304@securitycode.ru> (raw)
In-Reply-To: <20140404.102518.2263545144702348056.davem@davemloft.net>

On 04.04.2014 18:25, David Miller wrote:
> From: "Ilya V. Matveychikov" <matvejchikov@gmail.com>
> Date: Fri, 04 Apr 2014 01:33:04 +0400
> 
>> Keep peers MTU values synchronized. That prevent dropping packets
>> while
>> forwarding as diffirent MTU values prevent skb moving from one peer's
>> device to another (is_skb_forwardable returns false).
>>
>> Signed-off-by: Ilya V. Matveychikov <i.matveychikov@securitycode.ru>
> 
> Such side effects on another device when changing the configuration
> of one are strongly discouraged.
> 

Devices are paired. It means that one depends on another. Is there any case
where this "side" effect wouldn't be helpful?

> Furthermore, when the veth peer is created, no attempt is made to
> synchronize the MTUs.

Peers are created at once and ether_setup used for the configuration so MTU
values equals.

> 
> Let it therefore be the admins responsibility to keep them in sync
> just as it would be on a real network.
> 
> 

Different MTU values for the veth pairs are meaningless as if so we can't do the
communication between the namespaces at all. So, is it correct to shift all the
configuration problems to admins?

  reply	other threads:[~2014-04-04 14:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 21:33 [RFC PATCH] veth: keep peers MTU values synchronized Ilya V. Matveychikov
2014-04-04 14:25 ` David Miller
2014-04-04 14:42   ` Ilya V. Matveychikov [this message]
2014-04-04 14:49     ` David Miller
2014-04-04 15:04       ` Ilya V. Matveychikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533EC4D5.50304@securitycode.ru \
    --to=i.matveychikov@securitycode.ru \
    --cc=davem@davemloft.net \
    --cc=matvejchikov@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).