From: Heiner Kallweit <hkallweit1@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] r8169: remove not needed PHY soft reset in rtl8168e_2_hw_phy_config
Date: Wed, 21 Feb 2018 07:29:24 +0100 [thread overview]
Message-ID: <533d7dbc-f17a-d9fd-e9c8-0a2452f4c899@gmail.com> (raw)
In-Reply-To: <20180220.232748.29423773548892357.davem@davemloft.net>
Am 21.02.2018 um 05:27 schrieb David Miller:
> From: Heiner Kallweit <hkallweit1@gmail.com>
> Date: Tue, 20 Feb 2018 07:30:16 +0100
>
>> rtl8169_init_phy() resets the PHY anyway after applying the chip-specific
>> PHY configuration. So we don't need to soft-reset the PHY as part of the
>> chip-specific configuration.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> I'm not so comfortable with this.
>
> There are so many r8169 chip variants out there.
>
> And who knows, maybe one of them needs this second PHY reset or due to
> some way the driver is coded it is necessary.
>
> Unless you can test this change on every r8169 chip type, I'm very
> reluctant to apply this patch.
>
I understand the concern, the change however is in rtl8168e_2_hw_phy_config()
which is specific to chip version 34 (RTL8168evl).
On my system with this chip version the change didn't change system behavior.
> Sorry.
>
next prev parent reply other threads:[~2018-02-21 6:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 6:30 [PATCH net-next] r8169: remove not needed PHY soft reset in rtl8168e_2_hw_phy_config Heiner Kallweit
2018-02-21 4:27 ` David Miller
2018-02-21 6:29 ` Heiner Kallweit [this message]
2018-02-21 18:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533d7dbc-f17a-d9fd-e9c8-0a2452f4c899@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).