From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH v2] ipv6: Reparent temporary address(es) if global address was, deleted from userspace Date: Mon, 07 Apr 2014 20:50:32 +0200 Message-ID: <5342F378.5030400@web.de> References: <53423AF0.5080308@web.de> <20140407102229.GB27255@order.stressinduktion.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: Hannes Frederic Sowa , "netdev@vger.kernel.org" Return-path: Received: from mout.web.de ([212.227.17.11]:63352 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755356AbaDGSuh (ORCPT ); Mon, 7 Apr 2014 14:50:37 -0400 In-Reply-To: <20140407102229.GB27255@order.stressinduktion.org> Sender: netdev-owner@vger.kernel.org List-ID: Am 07.04.2014 12:22, schrieb Hannes Frederic Sowa: > On Mon, Apr 07, 2014 at 07:43:12AM +0200, Heiner Kallweit wrote: >> If the kernel takes care of global and temporary addresses it can happen >> that the global address is deleted from userspace, >> e.g. by network managers in case the link goes (temporarily) down. >> In addition to the then orphaned temporary address(es) the next RA will >> create a new temporary address. Therefore we might end up with more than >> one non-deprecated temporary address for the same prefix for a longer >> period of time (>regen_advance). According to RfC4941 sect. 3.4 this >> should not happen. >> >> Fix this by reparenting orphaned temporary addresses. >> >> v2: style fixes >> >> Signed-off-by: Heiner Kallweit > Looks good! > > Btw. do you intend this as a bugfix for net or net-next? net-next is currently > closed and you would have to resubmit this patch as soon as net-next opens > back up. A notification will be send to this list. > > Current kernels only print a warning if this happens, so IMHO net-next would > be ok? > > Thanks, > > Hannes > > Even though the kernel doesn't fully follow RfC 4941 in this scenario I didn't notice any real harm. Therefore I would agree and consider it more an improvement than a bugfix. I'll resubmit once net-next is open again. Regards, Heiner