From: Michal Marek <mmarek@suse.cz>
To: Joe Perches <joe@perches.com>,
Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Cc: "John W . Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, wil6210@qca.qualcomm.com,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/5] wil6210: Convert to Kbuild
Date: Thu, 10 Apr 2014 10:22:47 +0200 [thread overview]
Message-ID: <534654D7.4080904@suse.cz> (raw)
In-Reply-To: <1397059601.14321.19.camel@joe-AO722>
On 2014-04-09 18:06, Joe Perches wrote:
> (adding Michal Marek)
>
> On Wed, 2014-04-09 at 17:08 +0300, Vladimir Kondratiev wrote:
>> On Tuesday, April 08, 2014 09:14:51 AM Joe Perches wrote:
>>> On Tue, 2014-04-08 at 11:36 +0300, Vladimir Kondratiev wrote:
>>>> Convert Makefile -> Kbuild,
>>>> to make off-kernel development easier and less intrusive.
>>> No drivers/net directory uses Kbuild.
>>> Why should this?
>>
>> because it makes it easier to do off-kernel development, and then
>> move things to the proper location within the kernel without
>> conflicting changes in the Makefile.
You can create a GNUmakefile for this purpose, it takes precedence over
Makefile.
>> As I understand, Kbuild is better choice because it is really not
>> standalone "Makefile", it is intended to be included by the real
>> Makefile. Thus, distinct name is better.
>> Are there any reasons why not using Kbuild? I did not found
>> guidelines when use Kbuild and when not.
Kbuild is a slightly better choice because it better describes the
content, but I don't think its needed to rename existing Makefiles just
because of that. Kbuild is needed in the toplevel directory or in
arch/*/, where Makefile has a different special meaning. The out of tree
build use case can be solved by a GNUmakefile.
Michal
next prev parent reply other threads:[~2014-04-10 8:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1396946179-11677-1-git-send-email-qca_vkondrat@qca.qualcomm.com>
[not found] ` <1396946179-11677-2-git-send-email-qca_vkondrat@qca.qualcomm.com>
2014-04-08 16:14 ` [PATCH 1/5] wil6210: Convert to Kbuild Joe Perches
2014-04-09 14:08 ` Vladimir Kondratiev
2014-04-09 16:06 ` Joe Perches
2014-04-10 8:22 ` Michal Marek [this message]
2014-04-10 10:23 ` Vladimir Kondratiev
2014-04-10 11:06 ` Michal Marek
2014-04-10 12:37 ` Vladimir Kondratiev
2014-04-10 11:14 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534654D7.4080904@suse.cz \
--to=mmarek@suse.cz \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=qca_vkondrat@qca.qualcomm.com \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).