From: Michal Marek <mmarek@suse.cz>
To: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Cc: Joe Perches <joe@perches.com>,
"John W . Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, wil6210@qca.qualcomm.com,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/5] wil6210: Convert to Kbuild
Date: Thu, 10 Apr 2014 13:06:11 +0200 [thread overview]
Message-ID: <53467B23.6000407@suse.cz> (raw)
In-Reply-To: <1949326.Ead3K8R9Y2@lx-vladimir>
On 2014-04-10 12:23, Vladimir Kondratiev wrote:
> On Thursday, April 10, 2014 10:22:47 AM Michal Marek wrote:
>> Kbuild is a slightly better choice because it better describes the
>> content, but I don't think its needed to rename existing Makefiles just
>> because of that. Kbuild is needed in the toplevel directory or in
>> arch/*/, where Makefile has a different special meaning. The out of tree
>> build use case can be solved by a GNUmakefile.
>>
>
> Originally, I followed the code found at
> drivers/scsi/osd/
> They have Kbuild for in-kernel use and Makefile for out-of-tree
>
> But now I found, Documentation/kbuild/makefiles.txt says:
> ---cut---
> The preferred name for the kbuild files are 'Makefile' but 'Kbuild' can
> be used and if both a 'Makefile' and a 'Kbuild' file exists, then the 'Kbuild'
> file will be used.
> ---cut---
>
> Accordingly to this, would you say I should drop this patch and go with
> GNUmakefile + Makefile for internal development? I am pretty neutral with
> this, just need to know what is the proper way.
It's up to you, since it's your driver :). But the trick with
GNUmakefile works with the driver as-is as well as any other driver, so
it might be easier just to use that.
Michal
next prev parent reply other threads:[~2014-04-10 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1396946179-11677-1-git-send-email-qca_vkondrat@qca.qualcomm.com>
[not found] ` <1396946179-11677-2-git-send-email-qca_vkondrat@qca.qualcomm.com>
2014-04-08 16:14 ` [PATCH 1/5] wil6210: Convert to Kbuild Joe Perches
2014-04-09 14:08 ` Vladimir Kondratiev
2014-04-09 16:06 ` Joe Perches
2014-04-10 8:22 ` Michal Marek
2014-04-10 10:23 ` Vladimir Kondratiev
2014-04-10 11:06 ` Michal Marek [this message]
2014-04-10 12:37 ` Vladimir Kondratiev
2014-04-10 11:14 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53467B23.6000407@suse.cz \
--to=mmarek@suse.cz \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=qca_vkondrat@qca.qualcomm.com \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).