From: Daniel Borkmann <dborkman@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Masami Ichikawa <masami256@gmail.com>,
Alexei Starovoitov <ast@plumgrid.com>,
Will Drewry <wad@chromium.org>,
Josh Triplett <josh@joshtriplett.org>,
Rashika Kheria <rashika.kheria@gmail.com>,
James Morris <james.l.morris@oracle.com>,
davem@davemloft.net, eparis@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH] seccomp: fix memory leak on filter attach
Date: Mon, 14 Apr 2014 20:23:58 +0200 [thread overview]
Message-ID: <534C27BE.9020709@redhat.com> (raw)
In-Reply-To: <20140414171114.GA31384@www.outflux.net>
On 04/14/2014 07:11 PM, Kees Cook wrote:
> This sets the correct error code when final filter memory is unavailable,
> and frees the raw filter no matter what.
>
> unreferenced object 0xffff8800d6ea4000 (size 512):
> comm "sshd", pid 278, jiffies 4294898315 (age 46.653s)
> hex dump (first 32 bytes):
> 21 00 00 00 04 00 00 00 15 00 01 00 3e 00 00 c0 !...........>...
> 06 00 00 00 00 00 00 00 21 00 00 00 00 00 00 00 ........!.......
> backtrace:
> [<ffffffff8151414e>] kmemleak_alloc+0x4e/0xb0
> [<ffffffff811a3a40>] __kmalloc+0x280/0x320
> [<ffffffff8110842e>] prctl_set_seccomp+0x11e/0x3b0
> [<ffffffff8107bb6b>] SyS_prctl+0x3bb/0x4a0
> [<ffffffff8152ef2d>] system_call_fastpath+0x1a/0x1f
> [<ffffffffffffffff>] 0xffffffffffffffff
>
> Reported-by: Masami Ichikawa <masami256@gmail.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Cc: stable@vger.kernel.org
Acked-by: Daniel Borkmann <dborkman@redhat.com>
next prev parent reply other threads:[~2014-04-14 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 17:11 [PATCH] seccomp: fix memory leak on filter attach Kees Cook
2014-04-14 17:17 ` Alexei Starovoitov
2014-04-14 17:26 ` Kees Cook
2014-04-14 17:35 ` Alexei Starovoitov
2014-04-14 17:49 ` Kees Cook
2014-04-14 18:23 ` Daniel Borkmann [this message]
2014-04-14 23:30 ` Masami Ichikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534C27BE.9020709@redhat.com \
--to=dborkman@redhat.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=james.l.morris@oracle.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami256@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).