From: Daniel Borkmann <dborkman@redhat.com>
To: Alexander Sverdlin <alexander.sverdlin@nsn.com>
Cc: ext David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
matija.glavinic-pecotic.ext@nsn.com, vyasevich@gmail.com,
Peter Butler <pbutler@sonusnet.com>
Subject: Re: [PATCH net] Revert "net: sctp: Fix a_rwnd/rwnd management to reflect real state of the receiver's buffer"
Date: Tue, 15 Apr 2014 10:57:45 +0200 [thread overview]
Message-ID: <534CF489.1020007@redhat.com> (raw)
In-Reply-To: <534CF1CB.9090502@nsn.com>
On 04/15/2014 10:46 AM, Alexander Sverdlin wrote:
...
> Should not this be fixed actually in SCTP congestion control part?
> RWND calculation is actually not responsible for congestion control.
> And this revert actually introduces serious bug again, which leads to SCTP being stuck completely in particular
> multi-homed use-cases (refer to http://www.spinics.net/lists/linux-sctp/msg02516.html).
>
> We are not arguing against another version of the patch, but:
> - you are choosing speed instead of stability here
> - you are masking the problem reverting the code, which is not responsible for the problem observed
So on 10Gbit Ethernet it is reasonable to regress from 2Gbit down to 50Mbit???
Did you actually measure that? I'm not arguing against the original approach to
the fix, but you need to rework that for net-next just differently as Vlad
already stated, that's all.
next prev parent reply other threads:[~2014-04-15 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 19:45 [PATCH net] Revert "net: sctp: Fix a_rwnd/rwnd management to reflect real state of the receiver's buffer" Daniel Borkmann
2014-04-14 19:57 ` Vlad Yasevich
2014-04-16 6:57 ` Matija Glavinic Pecotic
2014-04-16 8:39 ` Dongsheng Song
2014-04-16 9:02 ` Alexander Sverdlin
2014-04-16 11:55 ` Matija Glavinic Pecotic
2014-04-16 13:32 ` Vlad Yasevich
2014-04-16 18:50 ` Vlad Yasevich
2014-04-16 19:05 ` Daniel Borkmann
2014-04-16 19:24 ` Matija Glavinic Pecotic
2014-04-16 19:47 ` Vlad Yasevich
2014-04-21 19:12 ` Matija Glavinic Pecotic
2014-04-14 20:48 ` David Miller
2014-04-15 8:46 ` Alexander Sverdlin
2014-04-15 8:57 ` Daniel Borkmann [this message]
2014-04-15 6:43 ` Alexander Sverdlin
2014-04-15 7:08 ` Daniel Borkmann
2014-04-15 14:27 ` Butler, Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534CF489.1020007@redhat.com \
--to=dborkman@redhat.com \
--cc=alexander.sverdlin@nsn.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=matija.glavinic-pecotic.ext@nsn.com \
--cc=netdev@vger.kernel.org \
--cc=pbutler@sonusnet.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).