From: "Ortwin Glück" <odi@odi.ch>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
gerben@daybyday.nl, Vlad Yasevich <vyasevic@redhat.com>
Subject: Re: 3.14 regression: huge latency in read/select on tun
Date: Sat, 19 Apr 2014 22:13:51 +0200 [thread overview]
Message-ID: <5352D8FF.6070305@odi.ch> (raw)
In-Reply-To: <1396533026.12330.9.camel@edumazet-glaptop2.roam.corp.google.com>
On 03.04.2014 15:50, Eric Dumazet wrote:
> On Thu, 2014-04-03 at 06:19 -0700, Eric Dumazet wrote:
>
>> It seems TSO support is broken.
I finally found time to bisect this:
53d6471cef17262d3ad1c7ce8982a234244f68ec is the first bad commit
commit 53d6471cef17262d3ad1c7ce8982a234244f68ec
Author: Vlad Yasevich <vyasevic@redhat.com>
Date: Thu Mar 27 17:26:18 2014 -0400
net: Account for all vlan headers in skb_mac_gso_segment
skb_network_protocol() already accounts for multiple vlan
headers that may be present in the skb. However, skb_mac_gso_segment()
doesn't know anything about it and assumes that skb->mac_len
is set correctly to skip all mac headers. That may not
always be the case. If we are simply forwarding the packet (via
bridge or macvtap), all vlan headers may not be accounted for.
A simple solution is to allow skb_network_protocol to return
the vlan depth it has calculated. This way skb_mac_gso_segment
will correctly skip all mac headers.
Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
:040000 040000 6066ee76dd70dde2f4675155579e550d29ba0216
2196ebff4f9a8b909617dd57beeaa76cbafc8525 M include
:040000 040000 20fdfb5efc1ada562b7899d0d58998914b1c2ff1
c398988f31e1b1b6ee56cb20b1a7becbdf782a17 M net
next prev parent reply other threads:[~2014-04-19 20:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 16:17 3.14 regression: huge latency in read/select on tun Ortwin Glück
2014-04-02 16:42 ` Eric Dumazet
2014-04-03 7:52 ` Ortwin Glück
2014-04-03 13:19 ` Eric Dumazet
2014-04-03 13:50 ` Eric Dumazet
2014-04-04 8:34 ` Ortwin Glück
2014-04-19 20:13 ` Ortwin Glück [this message]
2014-04-20 16:31 ` Eric Dumazet
2014-04-21 8:40 ` Ortwin Glück
2014-04-21 11:13 ` Lukas Tribus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5352D8FF.6070305@odi.ch \
--to=odi@odi.ch \
--cc=eric.dumazet@gmail.com \
--cc=gerben@daybyday.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).