netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ortwin Glück" <odi@odi.ch>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	gerben@daybyday.nl, Vlad Yasevich <vyasevic@redhat.com>
Subject: Re: 3.14 regression: huge latency in read/select on tun
Date: Mon, 21 Apr 2014 10:40:55 +0200	[thread overview]
Message-ID: <5354D997.70604@odi.ch> (raw)
In-Reply-To: <1398011495.19600.22.camel@edumazet-glaptop2.roam.corp.google.com>



On 20.04.2014 18:31, Eric Dumazet wrote:> On Sat, 2014-04-19 at 22:13
+0200, Ortwin Glück wrote:
>> On 03.04.2014 15:50, Eric Dumazet wrote:
>>
>> I finally found time to bisect this:
>>
>> commit 53d6471cef17262d3ad1c7ce8982a234244f68ec
>> Author: Vlad Yasevich <vyasevic@redhat.com>
>> Date:   Thu Mar 27 17:26:18 2014 -0400
>>
>>     net: Account for all vlan headers in skb_mac_gso_segment
>
> Hmm.. probably already solved by commit
> 1e785f48d29a09b6cf96db7b49b6320dada332e1
> ("net: Start with correct mac_len in skb_network_protocol")

Indeed that fixes it. I have cherry picked that onto 3.14 and it works.
That means 1e785f48 should be applied to stable 3.13.y and 3.14.y too.

Thanks,

Ortwin

  reply	other threads:[~2014-04-21  8:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02 16:17 3.14 regression: huge latency in read/select on tun Ortwin Glück
2014-04-02 16:42 ` Eric Dumazet
2014-04-03  7:52   ` Ortwin Glück
2014-04-03 13:19     ` Eric Dumazet
2014-04-03 13:50       ` Eric Dumazet
2014-04-04  8:34         ` Ortwin Glück
2014-04-19 20:13         ` Ortwin Glück
2014-04-20 16:31           ` Eric Dumazet
2014-04-21  8:40             ` Ortwin Glück [this message]
2014-04-21 11:13               ` Lukas Tribus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5354D997.70604@odi.ch \
    --to=odi@odi.ch \
    --cc=eric.dumazet@gmail.com \
    --cc=gerben@daybyday.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).