From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tushar Dave Subject: Re: [PATCH net-next 3/5] ebpf: Add sg_filter_run() Date: Wed, 12 Sep 2018 12:27:44 -0700 Message-ID: <535893cc-9d46-8ed0-737a-f30ea4ed0659@oracle.com> References: <1536694684-3200-1-git-send-email-tushar.n.dave@oracle.com> <1536694684-3200-4-git-send-email-tushar.n.dave@oracle.com> <20180912035846.3lwf4wrbqky7vpwe@ast-mbp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, santosh.shilimkar@oracle.com, jakub.kicinski@netronome.com, quentin.monnet@netronome.com, jiong.wang@netronome.com, sandipan@linux.vnet.ibm.com, john.fastabend@gmail.com, kafai@fb.com, rdna@fb.com, yhs@fb.com, netdev@vger.kernel.org, rds-devel@oss.oracle.com, sowmini.varadhan@oracle.com To: Alexei Starovoitov Return-path: Received: from aserp2120.oracle.com ([141.146.126.78]:32968 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728139AbeIMAe7 (ORCPT ); Wed, 12 Sep 2018 20:34:59 -0400 In-Reply-To: <20180912035846.3lwf4wrbqky7vpwe@ast-mbp> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 09/11/2018 08:58 PM, Alexei Starovoitov wrote: > On Tue, Sep 11, 2018 at 09:38:02PM +0200, Tushar Dave wrote: >> When sg_filter_run() is invoked it runs the attached eBPF >> prog of type BPF_PROG_TYPE_SOCKET_SG_FILTER which deals with >> struct scatterlist. >> >> Signed-off-by: Tushar Dave >> Acked-by: Sowmini Varadhan >> --- >> include/linux/filter.h | 8 ++++++++ >> include/uapi/linux/bpf.h | 6 ++++++ >> net/core/filter.c | 35 +++++++++++++++++++++++++++++++++++ >> tools/include/uapi/linux/bpf.h | 6 ++++++ >> 4 files changed, 55 insertions(+) >> >> diff --git a/include/linux/filter.h b/include/linux/filter.h >> index 6791a0a..ae664a9 100644 >> --- a/include/linux/filter.h >> +++ b/include/linux/filter.h >> @@ -1113,4 +1113,12 @@ struct bpf_sock_ops_kern { >> */ >> }; >> >> +enum __socksg_action { >> + __SOCKSG_PASS = 0, >> + __SOCKSG_DROP, >> + __SOCKSG_REDIRECT, > > what is this? I see no code that handles it either in this patch > or in the later patches?! Yes, I am not handling these actions in RDS in this patch series. I am thinking first I should have basic infrastructure in place (and want to make sure it works and accepted by community) then I will add more changes for RDS which includes handling socksg actions at RDS level. But fine, I can add code that handles socksg actions. Thanks -Tushar > >