netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <clm@fb.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH] ipv6: fib: fix fib dump restart
Date: Thu, 24 Apr 2014 10:43:15 -0400	[thread overview]
Message-ID: <53592303.4060100@fb.com> (raw)
In-Reply-To: <1398349084.29914.65.camel@edumazet-glaptop2.roam.corp.google.com>



On 04/24/2014 10:18 AM, Eric Dumazet wrote:
> On Thu, 2014-04-24 at 09:48 -0400, Chris Mason wrote:
>> From: Kumar Sundararajan <kumar@fb.com>
>>
>> When the ipv6 fib changes during a table dump, the walk is
>> restarted and the number of nodes dumped are skipped. But the existing
>> code doesn't advance to the next node after a node is skipped. This can
>> cause the dump to loop or produce lots of duplicates when the fib
>> is modified during the dump.
>>
>> This change advances the walk to the next node if the current node is
>> skipped after a restart.
>>
>> Signed-off-by: Chris Mason <clm@fb.com>
>> ---
>>   net/ipv6/ip6_fib.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> Hi Chris
>
> Who wrote the patch exactly ?
>
> If Kumar did, you need to put the
> "Signed-off-by: Kumar Sundararajan <kumar@fb.com>" before your own

Kumar did write it, I'll grab a sob from him.

-chris

  reply	other threads:[~2014-04-24 14:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24 13:48 [PATCH] ipv6: fib: fix fib dump restart Chris Mason
2014-04-24 14:18 ` Eric Dumazet
2014-04-24 14:43   ` Chris Mason [this message]
2014-04-24 20:26 ` Chris Mason
2014-04-24 20:31   ` David Miller
2014-04-24 21:20 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53592303.4060100@fb.com \
    --to=clm@fb.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).