From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [PATCH net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retrans'. Date: Fri, 25 Apr 2014 09:35:26 -0400 Message-ID: <535A649E.4090309@gmail.com> References: <1398367008-27452-1-git-send-email-kheiss@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-sctp@vger.kernel.org, nhorman@tuxdriver.com To: Karl Heiss , netdev@vger.kernel.org Return-path: Received: from mail-qa0-f45.google.com ([209.85.216.45]:50318 "EHLO mail-qa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbaDYNf3 (ORCPT ); Fri, 25 Apr 2014 09:35:29 -0400 In-Reply-To: <1398367008-27452-1-git-send-email-kheiss@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 04/24/2014 03:16 PM, Karl Heiss wrote: > Don't transition to the PF state on every strike after 'Path.Max.Retrans'. This > also prevents sending SCTP_ADDR_UNREACHABLE to the user as the state bounces > between SCTP_INACTIVE and SCTP_PF for each subsequent strike. > Good catch. We should never move to PF from INACTIVE. I'd rather you make it explicit by checking state rather then error counts. Thanks -vlad > Signed-off-by: Karl Heiss > --- > net/sctp/sm_sideeffect.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c > index 5d6883f..07f26fe 100644 > --- a/net/sctp/sm_sideeffect.c > +++ b/net/sctp/sm_sideeffect.c > @@ -502,7 +502,8 @@ static void sctp_do_8_2_transport_strike(sctp_cmd_seq_t *commands, > if ((transport->state != SCTP_PF) && > (transport->state != SCTP_UNCONFIRMED) && > (asoc->pf_retrans < transport->pathmaxrxt) && > - (transport->error_count > asoc->pf_retrans)) { > + (transport->error_count > asoc->pf_retrans) && > + (transport->error_count <= transport->pathmaxrxt)) { > > sctp_assoc_control_transport(asoc, transport, > SCTP_TRANSPORT_PF, >