From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [PATCH v3 net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retrans'. Date: Fri, 25 Apr 2014 13:22:37 -0400 Message-ID: <535A99DD.8070303@gmail.com> References: <1398445570-11429-1-git-send-email-kheiss@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-sctp@vger.kernel.org, davem@davemloft.net, nhorman@tuxdriver.com To: Karl Heiss , netdev@vger.kernel.org Return-path: Received: from mail-qc0-f177.google.com ([209.85.216.177]:40429 "EHLO mail-qc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbaDYRWl (ORCPT ); Fri, 25 Apr 2014 13:22:41 -0400 In-Reply-To: <1398445570-11429-1-git-send-email-kheiss@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 04/25/2014 01:06 PM, Karl Heiss wrote: > Don't transition to the PF state on every strike after 'Path.Max.Retrans'. > Per draft-ietf-tsvwg-sctp-failover-03 Section 5.1.6: > > Additional (PMR - PFMR) consecutive timeouts on a PF destination > confirm the path failure, upon which the destination transitions to the > Inactive state. As described in [RFC4960], the sender (i) SHOULD notify > ULP about this state transition, and (ii) transmit heartbeats to the > Inactive destination at a lower frequency as described in Section 8.3 of > [RFC4960]. > > This also prevents sending SCTP_ADDR_UNREACHABLE to the user as the state > bounces between SCTP_INACTIVE and SCTP_PF for each subsequent strike. > > Signed-off-by: Karl Heiss Acked-by: Vlad Yasevich -vlad > --- > Changes in v2: > - Flesh out commit message > > Changes in v3: > - Compare transport state instead of pathmaxrxt > > net/sctp/sm_sideeffect.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c > index 5d6883f..7805623 100644 > --- a/net/sctp/sm_sideeffect.c > +++ b/net/sctp/sm_sideeffect.c > @@ -496,11 +496,12 @@ static void sctp_do_8_2_transport_strike(sctp_cmd_seq_t *commands, > > /* If the transport error count is greater than the pf_retrans > * threshold, and less than pathmaxrtx, and if the current state > - * is not SCTP_UNCONFIRMED, then mark this transport as Partially > - * Failed, see SCTP Quick Failover Draft, section 5.1 > + * is not SCTP_UNCONFIRMED or SCTP_INACTIVE, then mark this transport > + * as Partially Failed, see SCTP Quick Failover Draft, section 5.1 > */ > if ((transport->state != SCTP_PF) && > (transport->state != SCTP_UNCONFIRMED) && > + (transport->state != SCTP_INACTIVE) && > (asoc->pf_retrans < transport->pathmaxrxt) && > (transport->error_count > asoc->pf_retrans)) { > >