netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: "Andrew J. Bennieston" <andrew.bennieston@citrix.com>,
	<ian.campbell@citrix.com>, <netdev@vger.kernel.org>,
	<paul.durrant@citrix.com>, <david.vrabel@citrix.com>,
	<zoltan.kiss@citrix.com>, <xen-devel@lists.xenproject.org>,
	<davem@davemloft.net>
Subject: Re: [Xen-devel] [PATCH V7 net-next 5/7] xen-netfront: Factor queue-specific data into queue struct.
Date: Wed, 30 Apr 2014 15:59:18 +0100	[thread overview]
Message-ID: <53610FC6.8000409@citrix.com> (raw)
In-Reply-To: <20140430145119.GE19082@zion.uk.xensource.com>

On 30/04/14 15:51, Wei Liu wrote:
> On Tue, Apr 29, 2014 at 02:27:13PM +0100, Andrew J. Bennieston wrote:
>> From: "Andrew J. Bennieston" <andrew.bennieston@citrix.com>
>>
>> In preparation for multi-queue support in xen-netfront, move the
>> queue-specific data from struct netfront_info to struct netfront_queue,
>> and update the rest of the code to use this.
>>
>> Also adds loops over queues where appropriate, even though only one is
>> configured at this point, and uses alloc_etherdev_mq() and the
>> corresponding multi-queue netif wake/start/stop functions in preparation
>> for multiple active queues.
>>
>> Finally, implements a trivial queue selection function suitable for
>> ndo_select_queue, which simply returns 0, selecting the first (and
>> only) queue.
>>
>> Signed-off-by: Andrew J. Bennieston <andrew.bennieston@citrix.com>
>> Reviewed-by: David Vrabel <david.vrabel@citrix.com>
> 
> Not an official netfront maintainer but FWIW this looks correct to me.

FYI, the frontend (including netfront) driver maintainers are the
general Xen maintainers; so myself, Boris and Konrad.

David

  reply	other threads:[~2014-04-30 14:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-29 13:27 [PATCH V7 net-next] xen-net{back, front}: Multiple transmit and receive queues Andrew J. Bennieston
2014-04-29 13:27 ` [PATCH V7 net-next 1/7] xen-netback: Move grant_copy_op array back into struct xenvif Andrew J. Bennieston
2014-04-30 14:50   ` Wei Liu
2014-04-29 13:27 ` [PATCH V7 net-next 2/7] xen-netback: Factor queue-specific data into queue struct Andrew J. Bennieston
2014-04-29 13:27 ` [PATCH V7 net-next 3/7] xen-netback: Add support for multiple queues Andrew J. Bennieston
2014-04-29 13:27 ` [PATCH V7 net-next 4/7] xen-netback: Correctly clean up after queue initialisation error Andrew J. Bennieston
2014-04-30 14:49   ` Wei Liu
2014-04-30 16:46     ` Andrew Bennieston
2014-04-29 13:27 ` [PATCH V7 net-next 5/7] xen-netfront: Factor queue-specific data into queue struct Andrew J. Bennieston
2014-04-30 14:51   ` Wei Liu
2014-04-30 14:59     ` David Vrabel [this message]
2014-04-29 13:27 ` [PATCH V7 net-next 6/7] xen-netfront: Add support for multiple queues Andrew J. Bennieston
2014-04-30 14:51   ` Wei Liu
2014-04-29 13:27 ` [PATCH V7 net-next 7/7] xen-net{back, front}: Document multi-queue feature in netif.h Andrew J. Bennieston
2014-04-30 14:51   ` [PATCH V7 net-next 7/7] xen-net{back,front}: " Wei Liu
2014-04-30 16:47     ` Andrew Bennieston
2014-04-30 14:50 ` [PATCH V7 net-next] xen-net{back,front}: Multiple transmit and receive queues Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53610FC6.8000409@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=andrew.bennieston@citrix.com \
    --cc=davem@davemloft.net \
    --cc=ian.campbell@citrix.com \
    --cc=netdev@vger.kernel.org \
    --cc=paul.durrant@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=zoltan.kiss@citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).