From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH] net: filter: add insn for loading internal transport header offset Date: Thu, 01 May 2014 12:55:23 +0200 Message-ID: <5362281B.3020802@redhat.com> References: <1398882591-30422-1-git-send-email-chema@google.com> <536227C1.20309@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Eric Dumazet , Alexei Starovoitov , netdev@vger.kernel.org To: Chema Gonzalez Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63638 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408AbaEAKz3 (ORCPT ); Thu, 1 May 2014 06:55:29 -0400 In-Reply-To: <536227C1.20309@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On 05/01/2014 12:53 PM, Daniel Borkmann wrote: > [ Chema, please also keep me in cc if possible. ] > > On 04/30/2014 08:29 PM, Chema Gonzalez wrote: >> Patch adds an ANC_TRA_OFFSET insn that loads the internal transport >> header of a packet ("internal" meaning after decapsulation by the >> flow dissector). >> >> Signed-off-by: Chema Gonzalez > > Looks good to me. For casting pointers as Dave noted recently, please > use 'unsigned long'. This needs to be fixed in other places as well. Ohh, and please in future include net or net-next into your subject line. > Other than that, you can add my: > > Acked-by: Daniel Borkmann