From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 13/18] ipv6: Export sernum update function Date: Sun, 7 Jan 2018 10:04:43 -0700 Message-ID: <53632fcb-af70-484b-983d-0ad9f3941846@gmail.com> References: <20180107104518.31693-1-idosch@mellanox.com> <20180107104518.31693-14-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, roopa@cumulusnetworks.com, nicolas.dichtel@6wind.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org, mlxsw@mellanox.com To: Ido Schimmel , netdev@vger.kernel.org Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:37968 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754175AbeAGREp (ORCPT ); Sun, 7 Jan 2018 12:04:45 -0500 Received: by mail-pl0-f66.google.com with SMTP id s10so6265740plj.5 for ; Sun, 07 Jan 2018 09:04:45 -0800 (PST) In-Reply-To: <20180107104518.31693-14-idosch@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/7/18 3:45 AM, Ido Schimmel wrote: > We are going to allow dead routes to stay in the FIB tree (e.g., when > they are part of a multipath route, directly connected route with no > carrier) and revive them when their nexthop device gains carrier or when > it is put administratively up. > > This is equivalent to the addition of the route to the FIB tree and we > should therefore take care of updating the sernum of all the parent > nodes of the node where the route is stored. Otherwise, we risk sockets > caching and using sub-optimal dst entries. > > Export the function that performs the above, so that it could be invoked > from fib6_ifup() later on. > > Signed-off-by: Ido Schimmel > --- > include/net/ip6_fib.h | 1 + > net/ipv6/ip6_fib.c | 11 ++++++++--- > 2 files changed, 9 insertions(+), 3 deletions(-) > Acked-by: David Ahern