netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Justin Lai <justinlai0215@realtek.com>
To: Paolo Abeni <pabeni@redhat.com>, "kuba@kernel.org" <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	Ping-Ke Shih <pkshih@realtek.com>,
	Larry Chiu <larry.chiu@realtek.com>
Subject: RE: [PATCH net-next v14 07/13] rtase: Implement a function to receive packets
Date: Mon, 18 Dec 2023 10:18:30 +0000	[thread overview]
Message-ID: <5368be1697534df09784f95d93b1f1fd@realtek.com> (raw)
In-Reply-To: <18552cff6fe32d4c21b4751cd6be4ff4757c63e8.camel@redhat.com>

> > +
> > +     cur_rx = ring->cur_idx;
> > +     entry = cur_rx % NUM_DESC;
> > +     desc = &desc_base[entry];
> > +
> > +     do {
> > +             /* make sure discriptor has been updated */
> > +             rmb();
> > +             status = le32_to_cpu(desc->desc_status.opts1);
> > +
> > +             if (status & DESC_OWN)
> > +                     break;
> > +
> > +             if (unlikely(status & RX_RES)) {
> > +                     if (net_ratelimit())
> > +                             netdev_warn(dev, "Rx ERROR. status =
> %08x\n",
> > +                                         status);
> > +
> > +                     dev->stats.rx_errors++;
> > +
> > +                     if (status & (RX_RWT | RX_RUNT))
> > +                             dev->stats.rx_length_errors++;
> 
> The device has a single RX queue, right? Otherwise this kind of stats
> accounting is going to be costly.
> 
> Cheers,
> 
> Paolo

Hi, Paolo

This device supports multiple RX queue.
Could you please provide an example of how you would like it done?

  parent reply	other threads:[~2023-12-18 10:18 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08  9:47 [PATCH net-next v14 00/13] Add Realtek automotive PCIe driver Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 01/13] rtase: Add pci table supported in this module Justin Lai
2023-12-12  9:36   ` Paolo Abeni
2023-12-12 16:05     ` Jakub Kicinski
2023-12-14 12:42     ` JustinLai0215
2023-12-08  9:47 ` [PATCH net-next v14 02/13] rtase: Implement the .ndo_open function Justin Lai
2023-12-12  9:49   ` Paolo Abeni
2023-12-14 12:44     ` JustinLai0215
2023-12-08  9:47 ` [PATCH net-next v14 03/13] rtase: Implement the rtase_down function Justin Lai
2023-12-12 19:27   ` Jakub Kicinski
2023-12-14 12:54     ` JustinLai0215
2023-12-08  9:47 ` [PATCH net-next v14 04/13] rtase: Implement the interrupt routine and rtase_poll Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 05/13] rtase: Implement hardware configuration function Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 06/13] rtase: Implement .ndo_start_xmit function Justin Lai
2023-12-12 19:32   ` Jakub Kicinski
2023-12-14 13:00     ` JustinLai0215
2023-12-14 17:24       ` Jakub Kicinski
2023-12-18 10:27     ` Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 07/13] rtase: Implement a function to receive packets Justin Lai
2023-12-12 10:04   ` Paolo Abeni
2023-12-14 12:45     ` JustinLai0215
2023-12-18 10:18     ` Justin Lai [this message]
2023-12-08  9:47 ` [PATCH net-next v14 08/13] rtase: Implement net_device_ops Justin Lai
2023-12-12 10:09   ` Paolo Abeni
2023-12-14 12:47     ` JustinLai0215
2023-12-08  9:47 ` [PATCH net-next v14 09/13] rtase: Implement pci_driver suspend and resume function Justin Lai
2023-12-12 19:19   ` Jakub Kicinski
2023-12-14 12:48     ` JustinLai0215
2023-12-08  9:47 ` [PATCH net-next v14 10/13] rtase: Implement ethtool function Justin Lai
2023-12-12 19:21   ` Jakub Kicinski
2023-12-08  9:47 ` [PATCH net-next v14 11/13] rtase: Add a Makefile in the rtase folder Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 12/13] realtek: Update the Makefile and Kconfig in the realtek folder Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 13/13] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
2023-12-12 19:22   ` Jakub Kicinski
2023-12-14 12:51     ` JustinLai0215
2023-12-14 17:27       ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5368be1697534df09784f95d93b1f1fd@realtek.com \
    --to=justinlai0215@realtek.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=larry.chiu@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).