From: Daniel Mack <zonque@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: mugunthanvnm <mugunthanvnm@ti.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: davinci_mdio: Use of_mdiobus_register()
Date: Tue, 06 May 2014 18:51:38 +0200 [thread overview]
Message-ID: <5369131A.1020908@gmail.com> (raw)
In-Reply-To: <CAGVrzcYH2BXTQ7bM_usz=ZuiAoU8PfNWVtDsxb6ONBxEimhDgw@mail.gmail.com>
On 05/06/2014 06:42 PM, Florian Fainelli wrote:
> 2014-05-06 8:18 GMT-07:00 Daniel Mack <zonque@gmail.com>:
>> of_mdiobus_register() calls mdiobus_register() internally, so the
>> functionality is preserved. However, by calling the of_ variant, phy
>> nodes can be augmented with extra information.
>
> Are there any non Device Tree aware platforms using this driver?
> of_mdiobus_register() is an empty stub returning -ENOSYS when
> CONFIG_OF is not set, maybe we should make it return
> mdiobus_register() instead...
Ah, good point. Yes, what you propose seems like a valid fix. I'll send
a patch for that.
Thanks,
Daniel
prev parent reply other threads:[~2014-05-06 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 15:18 [PATCH] net: davinci_mdio: Use of_mdiobus_register() Daniel Mack
2014-05-06 16:42 ` Florian Fainelli
2014-05-06 16:51 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5369131A.1020908@gmail.com \
--to=zonque@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).