From: Wang Weidong <wangweidong1@huawei.com>
To: David Miller <davem@davemloft.net>,
Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>
Cc: Daniel Borkmann <dborkman@redhat.com>,
<linux-sctp@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: [PATCH net-next] sctp: add a checking for sctp_sysctl_net_register
Date: Thu, 8 May 2014 15:55:05 +0800 [thread overview]
Message-ID: <536B3859.2050908@huawei.com> (raw)
When register_net_sysctl failed, we should free the
sysctl_table while the net_namespace is not init_net.
Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
---
net/sctp/sysctl.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c
index 844d2b0..4c17694 100644
--- a/net/sctp/sysctl.c
+++ b/net/sctp/sysctl.c
@@ -450,6 +450,11 @@ int sctp_sysctl_net_register(struct net *net)
}
net->sctp.sysctl_header = register_net_sysctl(net, "net/sctp", table);
+ if (net->sctp.sysctl_header == NULL) {
+ if (!net_eq(net, &init_net))
+ kfree(table);
+ return -ENOMEM;
+ }
return 0;
}
--
1.7.12
next reply other threads:[~2014-05-08 7:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 7:55 Wang Weidong [this message]
2014-05-08 9:40 ` [PATCH net-next] sctp: add a checking for sctp_sysctl_net_register tingwei liu
2014-05-08 11:11 ` Neil Horman
2014-05-08 11:26 ` Wang Weidong
2014-05-08 11:31 ` Wang Weidong
2014-05-08 11:41 ` Neil Horman
2014-05-08 11:57 ` Wang Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536B3859.2050908@huawei.com \
--to=wangweidong1@huawei.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).