* [PATCH] ptp: fix kconfig dependency warnings
@ 2014-05-08 21:54 Randy Dunlap
2014-05-09 4:29 ` Richard Cochran
2014-05-12 4:27 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2014-05-08 21:54 UTC (permalink / raw)
To: netdev@vger.kernel.org, David Miller, Richard Cochran; +Cc: Andrew Morton
From: Randy Dunlap <rdunlap@infradead.org>
Fix kconfig warnings:
PTP_1588_CLOCK selects NET_PTP_CLASSIFY, which depends on NET,
so PTP_1588_CLOCK should also depend on NET.
PTP_1588_CLOCK_PCH selects PTP_1588_CLOCK so the former should
depend on NET.
warning: (IXP4XX_ETH && PTP_1588_CLOCK) selects NET_PTP_CLASSIFY which has unmet direct dependencies (NET)
warning: (SFC && TILE_NET && BFIN_MAC_USE_HWSTAMP && TIGON3 && FEC && E1000E && IGB && IXGBE && I40E && MLX4_EN && SXGBE_ETH && STMMAC_ETH && TI_CPTS && PTP_1588_CLOCK_GIANFAR && PTP_1588_CLOCK_IXP46X && DP83640_PHY && PTP_1588_CLOCK_PCH) selects PTP_1588_CLOCK which has unmet direct dependencies (NET)
[This warning is caused by the new 'depends on NET' in PTP_1588_CLOCK.]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
drivers/ptp/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Found in linux-next but applies to mainline.
--- linux-next-20140508.orig/drivers/ptp/Kconfig
+++ linux-next-20140508/drivers/ptp/Kconfig
@@ -6,6 +6,7 @@ menu "PTP clock support"
config PTP_1588_CLOCK
tristate "PTP clock support"
+ depends on NET
select PPS
select NET_PTP_CLASSIFY
help
@@ -74,7 +75,7 @@ config DP83640_PHY
config PTP_1588_CLOCK_PCH
tristate "Intel PCH EG20T as PTP clock"
depends on X86 || COMPILE_TEST
- depends on HAS_IOMEM
+ depends on HAS_IOMEM && NET
select PTP_1588_CLOCK
help
This driver adds support for using the PCH EG20T as a PTP
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ptp: fix kconfig dependency warnings
2014-05-08 21:54 [PATCH] ptp: fix kconfig dependency warnings Randy Dunlap
@ 2014-05-09 4:29 ` Richard Cochran
2014-05-12 4:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2014-05-09 4:29 UTC (permalink / raw)
To: Randy Dunlap; +Cc: netdev@vger.kernel.org, David Miller, Andrew Morton
On Thu, May 08, 2014 at 02:54:42PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kconfig warnings:
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ptp: fix kconfig dependency warnings
2014-05-08 21:54 [PATCH] ptp: fix kconfig dependency warnings Randy Dunlap
2014-05-09 4:29 ` Richard Cochran
@ 2014-05-12 4:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-05-12 4:27 UTC (permalink / raw)
To: rdunlap; +Cc: netdev, richardcochran, akpm
From: Randy Dunlap <rdunlap@infradead.org>
Date: Thu, 08 May 2014 14:54:42 -0700
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kconfig warnings:
>
> PTP_1588_CLOCK selects NET_PTP_CLASSIFY, which depends on NET,
> so PTP_1588_CLOCK should also depend on NET.
>
> PTP_1588_CLOCK_PCH selects PTP_1588_CLOCK so the former should
> depend on NET.
>
> warning: (IXP4XX_ETH && PTP_1588_CLOCK) selects NET_PTP_CLASSIFY which has unmet direct dependencies (NET)
>
> warning: (SFC && TILE_NET && BFIN_MAC_USE_HWSTAMP && TIGON3 && FEC && E1000E && IGB && IXGBE && I40E && MLX4_EN && SXGBE_ETH && STMMAC_ETH && TI_CPTS && PTP_1588_CLOCK_GIANFAR && PTP_1588_CLOCK_IXP46X && DP83640_PHY && PTP_1588_CLOCK_PCH) selects PTP_1588_CLOCK which has unmet direct dependencies (NET)
> [This warning is caused by the new 'depends on NET' in PTP_1588_CLOCK.]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied, thanks Randy.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-12 4:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 21:54 [PATCH] ptp: fix kconfig dependency warnings Randy Dunlap
2014-05-09 4:29 ` Richard Cochran
2014-05-12 4:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).