From: George Cherian <george.cherian@ti.com>
To: Yuval Mintz <Yuval.Mintz@qlogic.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Cc: David Miller <davem@davemloft.net>,
"mugunthanvnm@ti.com" <mugunthanvnm@ti.com>,
"balbi@ti.com" <balbi@ti.com>,
"zonque@gmail.com" <zonque@gmail.com>,
"mpa@pengutronix.de" <mpa@pengutronix.de>,
"tklauser@distanz.ch" <tklauser@distanz.ch>
Subject: Re: [PATCH v2 2/3] net: davinci_mdio: Convert pr_err() to dev_err() call
Date: Fri, 9 May 2014 10:45:17 +0530 [thread overview]
Message-ID: <536C6465.6060907@ti.com> (raw)
In-Reply-To: <B5657A6538887040AD3A81F1008BEC63AD20DC@avmb3.qlogic.org>
On 5/8/2014 10:20 PM, Yuval Mintz wrote:
>> Also, Convert kzalloc to devm_kzalloc.
> Looks like you should remove this part of the comment.
Ah... Missed to update the commit log after rebasing patch to net-next.
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> Reviewed-by: Felipe Balbi <balbi@ti.com>
>> ---
>> drivers/net/ethernet/ti/davinci_mdio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/ti/davinci_mdio.c
>> b/drivers/net/ethernet/ti/davinci_mdio.c
>> index 34e97ec..735dc53 100644
>> --- a/drivers/net/ethernet/ti/davinci_mdio.c
>> +++ b/drivers/net/ethernet/ti/davinci_mdio.c
>> @@ -303,7 +303,7 @@ static int davinci_mdio_probe_dt(struct
>> mdio_platform_data *data,
>> return -EINVAL;
>>
>> if (of_property_read_u32(node, "bus_freq", &prop)) {
>> - pr_err("Missing bus_freq property in the DT.\n");
>> + dev_err(&pdev->dev, "Missing bus_freq property in the DT.\n");
>> return -EINVAL;
>> }
>> data->bus_freq = prop;
> ________________________________
>
> This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
--
-George
next prev parent reply other threads:[~2014-05-09 5:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 9:50 [PATCH v2 0/3] TI CPSW Cleanup George Cherian
2014-05-08 9:50 ` [PATCH v2 1/3] driver net: cpsw: Convert pr_*() to dev_*() calls George Cherian
2014-05-08 9:50 ` [PATCH v2 2/3] net: davinci_mdio: Convert pr_err() to dev_err() call George Cherian
2014-05-08 16:50 ` Yuval Mintz
2014-05-09 5:15 ` George Cherian [this message]
2014-05-08 9:50 ` [PATCH v2 3/3] drivers: net: davinci_cpdma: Convert kzalloc() to devm_kzalloc() George Cherian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536C6465.6060907@ti.com \
--to=george.cherian@ti.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).