From: zhuyj <zyjzyj2000@gmail.com>
To: eric.dumazet@gmail.com, "David S. Miller" <davem@davemloft.net>
Cc: "Tao, Yue" <Yue.Tao@windriver.com>, zhuyj <zyjzyj2000@gmail.com>,
linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: icmp: account for ICMP out errors because of socket limit
Date: Mon, 12 May 2014 11:19:28 +0800 [thread overview]
Message-ID: <53703DC0.2070204@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
Hi, Eric && David
____ ______________
| | | |
| PC |<------->| MIPS 32 core |
|____| |______________|
When ping from a PC to a board (MIPS 32 core), because of socket limit,
ping echo will fail. But ICMP_MIB_OUTERRORS counter is not incremented.
In this case, "netstat -s" can not report these errors.
This patch will fix this problem. Now it is in the attachment. Please
check it.
Best Regards!
Zhu Yanjun
[-- Attachment #2: 0001-icmp-account-for-ICMP-out-errors-because-of-socket-l.patch --]
[-- Type: text/x-patch, Size: 1025 bytes --]
>From af800d0f123cf9c66a9ae167baa7dc1d25d0cd1f Mon Sep 17 00:00:00 2001
From: Zhu Yanjun <Yanjun.Zhu@windriver.com>
Date: Mon, 12 May 2014 11:07:20 +0800
Subject: [PATCH 1/1] icmp: account for ICMP out errors because of socket
limit
When icmp_xmit_lock fails because of socket limit or memory shortage,
increment ICMP_MIB_OUTERRORS counter, so that "netstat -s" can report
these errors.
netstat -s | grep "ICMP messages failed"
0 ICMP messages failed
Signed-off-by: Zhu Yanjun <Yanjun.Zhu@windriver.com>
---
net/ipv4/icmp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
index 0134663..9a0bd7c 100644
--- a/net/ipv4/icmp.c
+++ b/net/ipv4/icmp.c
@@ -342,8 +342,10 @@ static void icmp_reply(struct icmp_bxm *icmp_param, struct sk_buff *skb)
return;
sk = icmp_xmit_lock(net);
- if (sk == NULL)
+ if (sk == NULL){
+ ICMP_INC_STATS_BH(net, ICMP_MIB_OUTERRORS);
return;
+ }
inet = inet_sk(sk);
icmp_param->data.icmph.checksum = 0;
--
1.7.9.5
next reply other threads:[~2014-05-12 3:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 3:19 zhuyj [this message]
2014-05-12 4:48 ` icmp: account for ICMP out errors because of socket limit zhuyj
2014-05-14 18:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53703DC0.2070204@gmail.com \
--to=zyjzyj2000@gmail.com \
--cc=Yue.Tao@windriver.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).