netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz@mellanox.com>
To: Jay Vosburgh <j.vosburgh@gmail.com>,
	Veaceslav Falico <vfalico@gmail.com>
Cc: Eyal Perry <eyalpe@mellanox.com>, netdev <netdev@vger.kernel.org>,
	Noa Osherovich <noaos@mellanox.com>
Subject: bonding directly changes underlying device address
Date: Tue, 13 May 2014 14:06:56 +0300	[thread overview]
Message-ID: <5371FCD0.7050502@mellanox.com> (raw)

Hi Jay, Veaceslav

I see  now that alb_set_slave_mac_addr directly changes the underlying 
device mac address without calling dev_set_mac_address when running in 
TLB mode. Is that on purpose? if yes, can you explain why?

I suspect this can lead to funny (or actually sad) bugs in networking 
drivers, can we avoid that?

Or.

             reply	other threads:[~2014-05-13 11:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 11:06 Or Gerlitz [this message]
2014-05-13 11:55 ` bonding directly changes underlying device address Jiri Pirko
2014-05-13 16:30   ` Jay Vosburgh
2014-05-13 17:38     ` Or Gerlitz
2014-05-14  8:01       ` Veaceslav Falico
2014-05-14  8:08         ` Or Gerlitz
2014-05-15  1:38         ` Jay Vosburgh
2014-05-15  4:55           ` Veaceslav Falico
2014-05-15 12:37             ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5371FCD0.7050502@mellanox.com \
    --to=ogerlitz@mellanox.com \
    --cc=eyalpe@mellanox.com \
    --cc=j.vosburgh@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=noaos@mellanox.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).