From: Carol Soto <clsoto@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, brking@linux.vnet.ibm.com
Subject: Re: [PATCH 0/1] mlx4: mlx4_core failed to load
Date: Tue, 13 May 2014 10:06:54 -0500 [thread overview]
Message-ID: <5372350E.7030100@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140428.155900.1619506417111671946.davem@davemloft.net>
On 4/28/2014 2:59 PM, David Miller wrote:
> From: clsoto@linux.vnet.ibm.com
> Date: Mon, 28 Apr 2014 13:33:30 -0500
>
>> This is for a case where mlx4_core fails to load.
> You cannot just will-nilly delete module parameters that you decide
> you don't want to support any more.
>
> Once you add a module parameter, you are stuck with it forever once
> it makes it into a released kernel. It is a user visible interface.
>
> I'm not applying this patch, you have to actually fix the bug rather
> then wholesale remove the facility altogether.
The problem here is that when use_prio argument is used then the number
of reserved qps increase from 0x20000 to 0x90000. So when it goes to
mlx4_bitmap_init the argument reserved_top becomes a lot bigger than
argument num, because of this then the math to get the size for the
kzalloc is very big. The argument num is the num of qps that the adapter
supports so then this sounds to me like a bug that if we use the
use_prio we can not have more qps reserved than the num qps that adapter
supports. That is why I went to the path of removing the argument in
this patch. Any other suggestion?
next prev parent reply other threads:[~2014-05-13 15:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 18:33 [PATCH 0/1] mlx4: mlx4_core failed to load clsoto
2014-04-28 18:33 ` [PATCH 1/1] mlx4: mlx4_core failed to load if use_prio argument is used clsoto
2014-04-28 19:59 ` [PATCH 0/1] mlx4: mlx4_core failed to load David Miller
2014-05-13 15:06 ` Carol Soto [this message]
2014-05-13 16:32 ` David Miller
2014-05-13 18:14 ` Carol Soto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5372350E.7030100@linux.vnet.ibm.com \
--to=clsoto@linux.vnet.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).