From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carol Soto Subject: Re: [PATCH 0/1] mlx4: mlx4_core failed to load Date: Tue, 13 May 2014 10:06:54 -0500 Message-ID: <5372350E.7030100@linux.vnet.ibm.com> References: <20140428183330.201681971@linux.vnet.ibm.com> <20140428.155900.1619506417111671946.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, brking@linux.vnet.ibm.com To: David Miller Return-path: Received: from e37.co.us.ibm.com ([32.97.110.158]:60356 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933602AbaEMPGv (ORCPT ); Tue, 13 May 2014 11:06:51 -0400 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 May 2014 09:06:51 -0600 Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 498D83E4003B for ; Tue, 13 May 2014 09:06:49 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by b03cxnp08027.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4DF5vBV10813908 for ; Tue, 13 May 2014 17:05:57 +0200 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id s4DFAelF028312 for ; Tue, 13 May 2014 09:10:41 -0600 In-Reply-To: <20140428.155900.1619506417111671946.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On 4/28/2014 2:59 PM, David Miller wrote: > From: clsoto@linux.vnet.ibm.com > Date: Mon, 28 Apr 2014 13:33:30 -0500 > >> This is for a case where mlx4_core fails to load. > You cannot just will-nilly delete module parameters that you decide > you don't want to support any more. > > Once you add a module parameter, you are stuck with it forever once > it makes it into a released kernel. It is a user visible interface. > > I'm not applying this patch, you have to actually fix the bug rather > then wholesale remove the facility altogether. The problem here is that when use_prio argument is used then the number of reserved qps increase from 0x20000 to 0x90000. So when it goes to mlx4_bitmap_init the argument reserved_top becomes a lot bigger than argument num, because of this then the math to get the size for the kzalloc is very big. The argument num is the num of qps that the adapter supports so then this sounds to me like a bug that if we use the use_prio we can not have more qps reserved than the num qps that adapter supports. That is why I went to the path of removing the argument in this patch. Any other suggestion?