* [PATCH -next] net: fix test_bpf build to depend on NET
@ 2014-05-13 16:58 Randy Dunlap
2014-05-13 17:04 ` Alexei Starovoitov
2014-05-13 17:16 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2014-05-13 16:58 UTC (permalink / raw)
To: netdev@vger.kernel.org, linux-next@vger.kernel.org, David Miller
From: Randy Dunlap <rdunlap@infradead.org>
Fix build when CONFIG_NET is not enabled.
Fixes these build errors:
WARNING: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
WARNING: "kfree_skb" [lib/test_bpf.ko] undefined!
WARNING: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
WARNING: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
WARNING: "__alloc_skb" [lib/test_bpf.ko] undefined!
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
lib/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20140513.orig/lib/Kconfig.debug
+++ linux-next-20140513/lib/Kconfig.debug
@@ -1639,7 +1639,7 @@ config TEST_USER_COPY
config TEST_BPF
tristate "Test BPF filter functionality"
default n
- depends on m
+ depends on m && NET
help
This builds the "test_bpf" module that runs various test vectors
against the BPF interpreter or BPF JIT compiler depending on the
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: fix test_bpf build to depend on NET
2014-05-13 16:58 [PATCH -next] net: fix test_bpf build to depend on NET Randy Dunlap
@ 2014-05-13 17:04 ` Alexei Starovoitov
2014-05-13 17:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2014-05-13 17:04 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev@vger.kernel.org, linux-next@vger.kernel.org, David Miller
On Tue, May 13, 2014 at 9:58 AM, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build when CONFIG_NET is not enabled.
> Fixes these build errors:
>
> WARNING: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
> WARNING: "kfree_skb" [lib/test_bpf.ko] undefined!
> WARNING: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
> WARNING: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
> WARNING: "__alloc_skb" [lib/test_bpf.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
ohh. yes. sorry about that.
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
> ---
> lib/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20140513.orig/lib/Kconfig.debug
> +++ linux-next-20140513/lib/Kconfig.debug
> @@ -1639,7 +1639,7 @@ config TEST_USER_COPY
> config TEST_BPF
> tristate "Test BPF filter functionality"
> default n
> - depends on m
> + depends on m && NET
> help
> This builds the "test_bpf" module that runs various test vectors
> against the BPF interpreter or BPF JIT compiler depending on the
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: fix test_bpf build to depend on NET
2014-05-13 16:58 [PATCH -next] net: fix test_bpf build to depend on NET Randy Dunlap
2014-05-13 17:04 ` Alexei Starovoitov
@ 2014-05-13 17:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-05-13 17:16 UTC (permalink / raw)
To: rdunlap; +Cc: netdev, linux-next
From: Randy Dunlap <rdunlap@infradead.org>
Date: Tue, 13 May 2014 09:58:44 -0700
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build when CONFIG_NET is not enabled.
> Fixes these build errors:
>
> WARNING: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
> WARNING: "kfree_skb" [lib/test_bpf.ko] undefined!
> WARNING: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
> WARNING: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
> WARNING: "__alloc_skb" [lib/test_bpf.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied, thanks Randy.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-13 17:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-13 16:58 [PATCH -next] net: fix test_bpf build to depend on NET Randy Dunlap
2014-05-13 17:04 ` Alexei Starovoitov
2014-05-13 17:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).