From: David Vrabel <david.vrabel@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Cc: Zoltan Kiss <zoltan.kiss@citrix.com>,
<xen-devel@lists.xenproject.org>, <wei.liu2@citrix.com>,
<linux@eikelenboom.it>, <paul.durrant@citrix.com>,
<netdev@vger.kernel.org>, <davem@davemloft.net>
Subject: Re: [PATCH net RFC] xen-netback: Fix grant ref resolution in RX path
Date: Wed, 14 May 2014 14:37:22 +0100 [thread overview]
Message-ID: <53737192.9050104@citrix.com> (raw)
In-Reply-To: <1400056335.21829.2.camel@kazak.uk.xensource.com>
On 14/05/14 09:32, Ian Campbell wrote:
>> I am not saying your patch is wrong, only that it adds yet an obscure
>> thing with no comments. In two years, nobody will understand this.
>
> Agreed.
The long term solution is to make grant copy use the supplied VA to copy
to/from which would mean we no longer need to pass the grant ref around
to do the copy.
This is non-trivial and would required an updated Xen.
It would also fix other use cases (such as a domU providing an iSCSI
target which is used as the block device for a local blkback).
David
next prev parent reply other threads:[~2014-05-14 13:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 14:31 [PATCH net RFC] xen-netback: Fix grant ref resolution in RX path Zoltan Kiss
2014-05-13 15:47 ` Ian Campbell
2014-05-13 20:18 ` Zoltan Kiss
2014-05-13 16:13 ` Eric Dumazet
2014-05-13 19:25 ` Sander Eikelenboom
2014-05-14 8:32 ` Ian Campbell
2014-05-14 13:37 ` David Vrabel [this message]
2014-05-14 11:12 ` Zoltan Kiss
2014-05-14 11:35 ` Eric Dumazet
2014-05-14 13:25 ` Zoltan Kiss
2014-05-14 16:40 ` Ian Campbell
2014-05-14 17:28 ` Sander Eikelenboom
2014-05-14 18:44 ` Zoltan Kiss
2014-05-15 8:41 ` Ian Campbell
2014-05-15 8:31 ` Ian Campbell
2014-05-15 10:14 ` Zoltan Kiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53737192.9050104@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux@eikelenboom.it \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zoltan.kiss@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).